IDEA-66336 Settings dialog will not open (use implementation class name as @NotNull default for getId() for settings component)

This commit is contained in:
irengrig
2011-03-09 18:47:09 +03:00
parent 9061a5d0bb
commit cdf75b460b
@@ -97,7 +97,13 @@ public class VcsManagerConfigurable extends SearchableConfigurable.Parent.Abstra
@NotNull
public String getId() {
return getClass().getName();
return getDefaultConfigurableIdValue(this);
}
@NotNull
private static String getDefaultConfigurableIdValue(final Configurable configurable) {
final String helpTopic = configurable.getHelpTopic();
return helpTopic == null ? configurable.getClass().getName() : helpTopic;
}
protected Configurable[] buildConfigurables() {
@@ -214,7 +220,7 @@ public class VcsManagerConfigurable extends SearchableConfigurable.Parent.Abstra
@NotNull
public String getId() {
return delegate instanceof SearchableConfigurable ? ((SearchableConfigurable) delegate).getId() : getHelpTopic();
return delegate instanceof SearchableConfigurable ? ((SearchableConfigurable) delegate).getId() : getDefaultConfigurableIdValue(this);
}
public Runnable enableSearch(String option) {