MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[codeInsight] Cleanup RedundantStringOperationInspection

Browse Source 
This patch cleans up the code from the reported warnings

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 655d37ae08c3cf7509c5c406afe47d4184a58986
This commit is contained in:
Nikita Eshkeev
2020-05-09 05:25:10 +00:00
committed by intellij-monorepo-bot
parent 597a92c0b2
commit cd8c6a31d4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/redundancy/RedundantStringOperationInspection.java
+2 -2
View File
@@ -315,7 +315,7 @@ public class RedundantStringOperationInspection extends AbstractBaseJavaLocalIns
// s.lastIndexOf(..., s.length()) or s.lastIndexOf(..., s.length() - 1)
if (stripped instanceof PsiBinaryExpression) {
PsiBinaryExpression binOp = (PsiBinaryExpression)stripped;
if (binOp.getOperationTokenType().equals(JavaTokenType.MINUS) &&
if (binOp.getOperationTokenType() == JavaTokenType.MINUS &&
ExpressionUtils.isLiteral(PsiUtil.skipParenthesizedExprDown(binOp.getROperand()), 1)) {
stripped = binOp.getLOperand();
}
@@ -672,7 +672,7 @@ public class RedundantStringOperationInspection extends AbstractBaseJavaLocalIns
private static void extractSideEffects(PsiExpression result, PsiStatement statement) {
List<PsiExpression> sideEffects = SideEffectChecker.extractSideEffectExpressions(result);
if (Collections.singletonList(result).equals(sideEffects)) return;
if (Objects.equals(Collections.singletonList(result), sideEffects)) return;
PsiStatement[] statements = StatementExtractor.generateStatements(sideEffects, result);
if (statements.length > 0) {