don't apply loose isReferenceTo() logic of qualified references with unknown qualifier type to __init__ calls (otherwise we get very weird results when searching usages of class) (PY-1450)

This commit is contained in:
Dmitry Jemerov
2010-07-27 21:34:52 +04:00
parent 8471792721
commit cc3647f65b
3 changed files with 10 additions and 1 deletions
@@ -8,6 +8,7 @@ import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
import com.intellij.util.ArrayUtil;
import com.intellij.util.ProcessingContext;
import com.jetbrains.python.PyNames;
import com.jetbrains.python.psi.*;
import com.jetbrains.python.psi.patterns.SyntaxMatchers;
import com.jetbrains.python.psi.resolve.*;
@@ -242,7 +243,7 @@ public class PyQualifiedReferenceImpl extends PyReferenceImpl {
}
final String referencedName = myElement.getReferencedName();
if (element instanceof PyFunction && Comparing.equal(referencedName, ((PyFunction)element).getName()) &&
((PyFunction)element).getContainingClass() != null) {
((PyFunction)element).getContainingClass() != null && !PyNames.INIT.equals(referencedName)) {
final PyExpression qualifier = myElement.getQualifier();
if (qualifier != null && qualifier.getType(TypeEvalContext.fast()) == null) {
return true;
@@ -0,0 +1,3 @@
class <caret>B(C):
def __init__(self):
C.__init__(self)
@@ -54,6 +54,11 @@ public class PyFindUsagesTest extends PyLightFixtureTestCase {
assertUsages(usages, "<caret>parm+1");
}
public void testUnresolvedClassInit() { // PY-1450
final Collection<UsageInfo> usages = myFixture.testFindUsages("findUsages/UnresolvedClassInit.py");
assertUsages(usages);
}
private void assertUsages(Collection<UsageInfo> usages, String... usageTexts) {
assertEquals(usageTexts.length, usages.size());
List<UsageInfo> sortedUsages = new ArrayList<UsageInfo>(usages);