MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

extract parameter object: warn if existing class doesn't contain compatible constructor though method calls to modify are found

Browse Source
This commit is contained in:
Anna.Kozlova
2016-04-19 19:05:54 +02:00
parent e00394804a
commit cb339bf590
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/refactoring/introduceparameterobject/JavaIntroduceParameterObjectDelegate.java
+5
View File
@@ -279,6 +279,7 @@ public class JavaIntroduceParameterObjectDelegate
}
if (moveDestination != null) {
boolean constructorMiss = false;
for (UsageInfo info : infos) {
if (info instanceof IntroduceParameterObjectProcessor.ChangeSignatureUsageWrapper) {
final UsageInfo usageInfo = ((IntroduceParameterObjectProcessor.ChangeSignatureUsageWrapper)info).getInfo();
@@ -289,6 +290,10 @@ public class JavaIntroduceParameterObjectDelegate
conflicts.putValue(overridingMethod, "Created class won't be accessible");
}
}
if (!constructorMiss && classDescriptor.isUseExistingClass() && usageInfo instanceof MethodCallUsageInfo && classDescriptor.getExistingClassCompatibleConstructor() == null) {
conflicts.putValue(classDescriptor.getExistingClass(), "Existing class misses compatible constructor");
constructorMiss = true;
}
}
}
}