MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 14:23:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

IJPL-166285 Fix accessing unregistered RPC breaks following RPC calls

Browse Source 
If RPC is not followed, backend throws an error `No remote API found for InstanceId` in `RemoteApiRegistry.resolve`.
`RpcExecutor`, however, expects this method to return `null` if service was not found, not an exception.

Therefore, the exception is propagated upward which breaks the kernel and prevents further RPC calls from executing.

We should adhere to the API requirements and return `null` if service was not found instead of throwing an error.

GitOrigin-RevId: bbf70f1fe1cb0e7fb80bcc72ca0b161452a36f58
This commit is contained in:
Kate Botsman
2024-11-06 10:47:41 +01:00
committed by intellij-monorepo-bot
parent 6f9ba26707
commit c86bc3c11d
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
platform/kernel/rpc.backend/src/impl/RemoteApiRegistry.kt
View File

@@ -67,8 +67,7 @@ internal class RemoteApiRegistry(coroutineScope: CoroutineScope) : RemoteApiProv
?: throw IllegalStateException("No remote API found for $descriptor")
}
override fun resolve(serviceId: InstanceId): ServiceImplementation {
override fun resolve(serviceId: InstanceId): ServiceImplementation? {
return remoteApis[serviceId.id]
?: throw IllegalStateException("No remote API found for $serviceId")
}
}