IDEA-122250 New Package: qualified name is checked against ignored directories as a whole

This commit is contained in:
peter
2014-04-18 22:37:33 +02:00
parent 3af306c66e
commit c6fcabfcc2
@@ -40,6 +40,7 @@ import org.jetbrains.annotations.Nullable;
import javax.swing.*;
import java.awt.*;
import java.io.File;
import java.util.List;
public class CreateDirectoryOrPackageHandler implements InputValidatorEx {
@Nullable private final Project myProject;
@@ -75,11 +76,14 @@ public class CreateDirectoryOrPackageHandler implements InputValidatorEx {
@Override
public String getErrorText(String inputString) {
if (FileTypeManager.getInstance().isFileIgnored(inputString)) {
return "Trying to create a " + (myIsDirectory ? "directory" : "package") + " with ignored name, result will not be visible";
}
if (!myIsDirectory && inputString.length() > 0 && !PsiDirectoryFactory.getInstance(myProject).isValidPackageName(inputString)) {
return "Not a valid package name, it would be impossible to create a class inside";
List<String> strings = StringUtil.split(inputString, ".");
for (String part : strings) {
if (FileTypeManager.getInstance().isFileIgnored(part)) {
return "Trying to create a " + (myIsDirectory ? "directory" : "package") + " with ignored name, result will not be visible";
}
if (!myIsDirectory && part.length() > 0 && !PsiDirectoryFactory.getInstance(myProject).isValidPackageName(part)) {
return "Not a valid package name, it would be impossible to create a class inside";
}
}
return null;
}