MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

regexp: nicer highlighted range for "Unresolved named group reference"

Browse Source
This commit is contained in:
Bas Leijdekkers
2016-08-14 23:01:20 +02:00
parent 4dd70c3478
commit c6ce31fba3
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
RegExpSupport/src/org/intellij/lang/regexp/validation/RegExpAnnotator.java
View File

@@ -290,7 +290,8 @@ public final class RegExpAnnotator extends RegExpElementVisitor implements Annot
}
final RegExpGroup group = groupRef.resolve();
if (group == null) {
final Annotation a = myHolder.createErrorAnnotation(groupRef, "Unresolved named group reference");
final ASTNode node = groupRef.getNode().findChildByType(RegExpTT.NAME);
final Annotation a = myHolder.createErrorAnnotation(node, "Unresolved named group reference");
if (a != null) {
// IDEA-9381
a.setHighlightType(ProblemHighlightType.LIKE_UNKNOWN_SYMBOL);

2
RegExpSupport/testData/RETest.xml
View File

@@ -76,7 +76,7 @@
<expected>OK</expected>
</test>
<test host="com.intellij.psi.impl.JavaRegExpHost">
<pattern><![CDATA[<error descr="Unresolved named group reference">\k<adsf></error>]]></pattern>
<pattern><![CDATA[\k<<error descr="Unresolved named group reference">adsf</error>>]]></pattern>
<expected>OK</expected>
</test>
</groups>