MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-03-22 15:19:59 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-75934 Jupyter(fix): Start use JupyterFileUtils for all converts from source file,text Add dispose for all listeners of NotebookCellInlayManager

Browse Source 
GitOrigin-RevId: 226851fe8e5ebeed8492f058883ca4dc144898d4
This commit is contained in:
Nikita.Ashihmin
2024-10-01 22:15:31 +04:00
committed by intellij-monorepo-bot
parent 546cb1e600
commit c6a8189580
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
notebooks/visualization/src/com/intellij/notebooks/visualization/NotebookCellInlayManager.kt
View File

@@ -29,6 +29,7 @@ import com.intellij.openapi.editor.impl.EditorImpl
import com.intellij.openapi.util.Disposer
import com.intellij.openapi.util.Key
import com.intellij.openapi.util.registry.Registry
import com.intellij.openapi.util.removeUserData
import com.intellij.util.EventDispatcher
import com.intellij.util.SmartList
import com.intellij.util.concurrency.ThreadingAssertions
@@ -103,7 +104,9 @@ class NotebookCellInlayManager private constructor(
}
}
override fun dispose() {}
override fun dispose() {
editor.removeUserData(CELL_INLAY_MANAGER_KEY)
}
fun getCellForInterval(interval: NotebookCellLines.Interval): EditorCell =
_cells[interval.ordinal]
@@ -158,8 +161,6 @@ class NotebookCellInlayManager private constructor(
}
private fun initialize() {
// TODO It would be a cool approach to add inlays lazily while scrolling.
editor.putUserData(CELL_INLAY_MANAGER_KEY, this)
val connection = ApplicationManager.getApplication().messageBus.connect(editor.disposable)
@@ -203,7 +204,7 @@ class NotebookCellInlayManager private constructor(
}
postponedUpdates.clear()
}
})
}, this)
handleRefreshedDocument()
}
@@ -262,7 +263,7 @@ class NotebookCellInlayManager private constructor(
override fun caretPositionChanged(event: CaretEvent) {
updateSelection()
}
})
}, this)
}
private fun updateSelection() {
@@ -316,7 +317,7 @@ class NotebookCellInlayManager private constructor(
}
}
}
}, editor.disposable)
}, this)
}
private fun editorCells(region: FoldRegion): List<EditorCell> = _cells.filter { cell ->
@@ -373,7 +374,7 @@ class NotebookCellInlayManager private constructor(
).also { Disposer.register(editor.disposable, it) }
editor.putUserData(isFoldingEnabledKey, Registry.`is`("jupyter.editor.folding.cells"))
notebookCellInlayManager.initialize()
NotebookIntervalPointerFactory.get(editor).changeListeners.addListener(notebookCellInlayManager, editor.disposable)
NotebookIntervalPointerFactory.get(editor).changeListeners.addListener(notebookCellInlayManager, notebookCellInlayManager)
return notebookCellInlayManager
}