MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

LengthOneStringInConcatenationInspection: support parentheses

Browse Source
This commit is contained in:
Tagir Valeev
2018-07-06 13:58:52 +07:00
parent 1325835ce7
commit c69fc7d594
3 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/LengthOneStringsInConcatenationInspection.java
+2 -1
View File
@@ -19,6 +19,7 @@ import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.text.StringUtil;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
@@ -118,7 +119,7 @@ public class LengthOneStringsInConcatenationInspection
}
static boolean isArgumentOfStringAppend(PsiExpression expression) {
final PsiElement parent = expression.getParent();
final PsiElement parent = PsiUtil.skipParenthesizedExprUp(expression.getParent());
if (parent == null) {
return false;
}
plugins/InspectionGadgets/test/com/siyeh/igtest/performance/length_one_strings_in_concatenation/LengthOneStringInConcatenationInspection.java
+1
View File
@@ -23,5 +23,6 @@ public class LengthOneStringInConcatenationInspection
System.out.println(1 + "b" + "asdf");
System.out.println("a" + );
System.out.println("asdf" + ("b") + 2);
buffer2.append(("p"));
}
}
plugins/InspectionGadgets/test/com/siyeh/igtest/performance/length_one_strings_in_concatenation/expected.xml
+7
View File
@@ -55,4 +55,11 @@
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Single character string concatenation</problem_class>
<description>&lt;code&gt;&quot;b&quot;&lt;/code&gt; can be replaced with 'b' #loc</description>
</problem>
<problem>
<file>LengthOneStringInConcatenationInspection.java</file>
<line>26</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Single character string concatenation</problem_class>
<description>&lt;code&gt;&quot;p&quot;&lt;/code&gt; can be replaced with 'p' #loc</description>
</problem>
</problems>