MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-03-22 06:50:54 +07:00
Code Issues Packages Projects Releases Wiki Activity

[diagnostics] IJPL-165781 Mute problem for freeze notification in plugins per Major.Minor IDE version

Browse Source 
(cherry picked from commit 780fc8394e471b3507f530a2ca6f16584269702a)

IJ-CR-148367

GitOrigin-RevId: 8c3e65e241fae0e8bbd035f48481c64b9ed5dade
This commit is contained in:
Yuriy Artamonov
2024-11-01 19:33:54 +01:00
committed by intellij-monorepo-bot
parent 159c209efd
commit c5570569e0
3 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
platform/diagnostic/freezeInPluginNotifier/resources/messages/PluginFreezeBundle.properties
View File

@@ -1,5 +1,5 @@
action.close.panel.text=Dismiss
action.ignore.plugin.text=Ignore
action.ignore.plugin.text=Mute problem
notification.content.freeze.detected={0} has encountered a slowdown
notification.content.plugin.caused.freeze=Plugin ''{0}'' might be slowing things down
action.report.text=Report problem

2
platform/diagnostic/freezeInPluginNotifier/src/com/intellij/platform/diagnostic/plugin/freeze/PluginFreezeNotificationPanel.kt
View File

@@ -100,6 +100,8 @@ internal class PluginFreezeNotificationPanel : EditorNotificationProvider {
override fun updateOnSubmit() {
super.updateOnSubmit()
PluginsFreezesService.getInstance().mutePlugin(pluginDescriptor.pluginId)
LifecycleUsageTriggerCollector.pluginFreezeReported(pluginDescriptor.pluginId)
closePanel(project)
}

28
platform/diagnostic/freezeInPluginNotifier/src/com/intellij/platform/diagnostic/plugin/freeze/PluginsFreezesServiceState.kt
View File

@@ -1,6 +1,7 @@
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.platform.diagnostic.plugin.freeze
import com.intellij.openapi.application.ApplicationInfo
import com.intellij.openapi.components.*
import com.intellij.openapi.extensions.PluginId
import java.time.Instant
@@ -22,7 +23,19 @@ internal class PluginsFreezesService : PersistentStateComponent<PluginsFreezesSe
}
fun mutePlugin(pluginId: PluginId) {
state.mutedPlugins[pluginId.idString] = true
val ideVersion = mutedProblemVersion()
state.mutedPlugins += MutedPlugin().apply {
this.pluginId = pluginId.idString
this.ideVersion = ideVersion
}
state.mutedPlugins.removeIf { it.ideVersion != ideVersion }
}
private fun mutedProblemVersion(): String {
val app = ApplicationInfo.getInstance()
return app.majorVersion + "." + app.minorVersion
}
fun setLatestFreezeDate(pluginId: PluginId) {
@@ -36,7 +49,11 @@ internal class PluginsFreezesService : PersistentStateComponent<PluginsFreezesSe
fun shouldBeIgnored(pluginId: PluginId): Boolean {
val pluginIdString = pluginId.idString
if (state.mutedPlugins[pluginIdString] == true) return true
val ideVersion = mutedProblemVersion()
if (state.mutedPlugins.any { p -> p.pluginId == pluginIdString && p.ideVersion == ideVersion }) {
return true
}
val lastNotification = state.latestNotificationTime[pluginIdString]?.let { Instant.parse(it) } ?: return false
return Instant.now().isBefore(lastNotification.plus(NOTIFICATION_COOLDOWN_DAYS, ChronoUnit.DAYS))
@@ -51,5 +68,10 @@ internal class PluginsFreezesService : PersistentStateComponent<PluginsFreezesSe
internal data class PluginsFreezesServiceState(
var latestNotificationTime: MutableMap<String, String> = mutableMapOf(),
var mutedPlugins: MutableMap<String, Boolean> = mutableMapOf(),
var mutedPlugins: MutableList<MutedPlugin> = mutableListOf(),
)
internal class MutedPlugin: BaseState() {
var pluginId by string()
var ideVersion by string()
}