MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

RIDER-84095 Manual follow redirects to avoid leak Authorization header into redirected request.

Browse Source 
GitOrigin-RevId: 8d56c83a28f63295861e4b3deff74f42c4d9339c
This commit is contained in:
Mikhail Filippov
2022-10-28 18:15:06 +00:00
committed by intellij-monorepo-bot
parent 0db283e12e
commit c480c032ff
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/build-scripts/downloader/src/org/jetbrains/intellij/build/dependencies/BuildDependenciesDownloader.java
+16 -1
View File
@@ -29,6 +29,7 @@ import java.time.Instant;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.locks.Lock;
@@ -59,7 +60,7 @@ public final class BuildDependenciesDownloader {
// init is very expensive due to SSL initialization
private static final class HttpClientHolder {
private static final HttpClient httpClient = HttpClient.newBuilder().followRedirects(HttpClient.Redirect.NORMAL)
private static final HttpClient httpClient = HttpClient.newBuilder().followRedirects(HttpClient.Redirect.NEVER)
.version(HttpClient.Version.HTTP_1_1).build();
}
@@ -379,6 +380,20 @@ public final class BuildDependenciesDownloader {
HttpResponse<Path> response = HttpClientHolder.httpClient.send(request, HttpResponse.BodyHandlers.ofFile(tempFile));
int statusCode = response.statusCode();
if (statusCode == 301 || statusCode == 302 || statusCode == 307 || statusCode == 308) {
Optional<String> locationHeader = response.headers().firstValue("Location");
if (locationHeader.isPresent()) {
requestBuilder = HttpRequest.newBuilder()
.GET()
.uri(new URI(locationHeader.get()))
.setHeader("User-Agent", "Build Script Downloader");
request = requestBuilder.build();
response = HttpClientHolder.httpClient.send(request, HttpResponse.BodyHandlers.ofFile(tempFile));
statusCode = response.statusCode();
}
}
if (statusCode != 200) {
StringBuilder builder = new StringBuilder("Cannot download\n");