java completion: disprefer primitive types inside generics (IDEA-166668)

This commit is contained in:
peter
2017-01-21 14:22:05 +01:00
parent 77f9e419b5
commit c2935ef5ea
2 changed files with 3 additions and 2 deletions
@@ -263,7 +263,8 @@ public class PreferByKindWeigher extends LookupElementWeigher {
}
if (JavaKeywordCompletion.PRIMITIVE_TYPES.contains(keyword) || PsiKeyword.VOID.equals(keyword)) {
boolean inCallArg = psiElement().withParents(PsiReferenceExpression.class, PsiExpressionList.class).accepts(myPosition);
return inCallArg ? ThreeState.NO : ThreeState.UNSURE;
boolean inTypeArg = psiElement().inside(PsiReferenceParameterList.class).accepts(myPosition);
return inCallArg || inTypeArg ? ThreeState.NO : ThreeState.UNSURE;
}
return ThreeState.UNSURE;
}
@@ -706,7 +706,7 @@ class ContainerUtil extends ContainerUtilRt {
}
void testPreferExpectedMethodTypeArg() {
checkPreferredItems 0, 'String'
checkPreferredItems 0, 'String', 'Usage'
}
void testMethodStatisticsPerQualifierType() {