MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

no dialogs under write action in python AddFunctionQuickFix (EA-99361 - assert: NoSwingUnderWriteAction.a)

Browse Source
This commit is contained in:
peter
2017-03-22 18:43:01 +01:00
parent 571432b604
commit c28425f017
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/quickfix/AddFunctionQuickFix.java
+13 -4
View File
@@ -21,6 +21,7 @@ import com.intellij.codeInsight.template.TemplateBuilder;
import com.intellij.codeInsight.template.TemplateBuilderFactory;
import com.intellij.codeInspection.LocalQuickFix;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.application.WriteAction;
import com.intellij.openapi.editor.Editor;
import com.intellij.openapi.extensions.Extensions;
import com.intellij.openapi.fileEditor.FileEditorManager;
@@ -72,6 +73,11 @@ public class AddFunctionQuickFix implements LocalQuickFix {
return "Create function in module";
}
@Override
public boolean startInWriteAction() {
return false;
}
public void applyFix(@NotNull Project project, @NotNull ProblemDescriptor descriptor) {
try {
final PsiElement problemElement = descriptor.getPsiElement();
@@ -116,11 +122,14 @@ public class AddFunctionQuickFix implements LocalQuickFix {
}
}
// else: no arglist, use empty args
PyFunction function = builder.buildFunction(project, LanguageLevel.forElement(file));
// add to the bottom
function = (PyFunction) file.add(function);
showTemplateBuilder(function, file);
WriteAction.run(() -> {
PyFunction function = builder.buildFunction(project, LanguageLevel.forElement(file));
// add to the bottom
function = (PyFunction) file.add(function);
showTemplateBuilder(function, file);
});
}
catch (IncorrectOperationException ignored) {
// we failed. tell about this