MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

fixed PY-12526 Replace with str format method call: unnecessary u prefix for python 3

Browse Source
This commit is contained in:
Ekaterina Tuzova
2014-04-02 15:18:58 +04:00
parent 2c66b01897
commit c25dd56396
4 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/codeInsight/intentions/PyStringConcatenationToFormatIntention.java
+2 -1
View File
@@ -140,10 +140,11 @@ public class PyStringConcatenationToFormatIntention extends BaseIntentionAction
int paramCount = 0;
boolean isUnicode = false;
final PyClassTypeImpl unicodeType = PyBuiltinCache.getInstance(element).getObjectType("unicode");
for (PyExpression expression : getSimpleExpressions((PyBinaryExpression) element)) {
if (expression instanceof PyStringLiteralExpression) {
final PyType type = context.getType(expression);
if (PyTypeChecker.match(unicodeType, type, context)) {
if (type != null && type.equals(unicodeType)) {
isUnicode = true;
}
if (!quotesDetected) {
python/testData/intentions/PyStringConcatenationToFormatIntentionTest/py3Unicode.py
+2
View File
@@ -0,0 +1,2 @@
string = "qwer<caret>" + "asdf"
python/testData/intentions/PyStringConcatenationToFormatIntentionTest/py3Unicode_after.py
+2
View File
@@ -0,0 +1,2 @@
string = "qwerasdf"
python/testSrc/com/jetbrains/python/intentions/PyStringConcatenationToFormatIntentionTest.java
+4
View File
@@ -73,4 +73,8 @@ public class PyStringConcatenationToFormatIntentionTest extends PyIntentionTestC
public void testPy3() { //PY-4706
doTest(PyBundle.message("INTN.replace.plus.with.str.format"), LanguageLevel.PYTHON33);
}
public void testPy3Unicode() {
doTest(PyBundle.message("INTN.replace.plus.with.str.format"), LanguageLevel.PYTHON33);
}
}