MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-10-06 06:21:16 +07:00
Code Issues Packages Projects Releases Wiki Activity

check Pair types with actual parameters types

Browse Source
This commit is contained in:
Konstantin Bulenkov
2014-05-08 13:23:28 +02:00
parent 16906b2493
commit c1980f4611
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/devkit/src/inspections/internal/DontUseNewPairInspection.java
+13 -6
View File
@@ -18,15 +18,15 @@ package org.jetbrains.idea.devkit.inspections.internal;
import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.pom.java.LanguageLevel;
import com.intellij.psi.JavaElementVisitor;
import com.intellij.psi.PsiElementVisitor;
import com.intellij.psi.PsiNewExpression;
import com.intellij.psi.PsiType;
import com.intellij.psi.*;
import com.intellij.psi.impl.source.PsiClassReferenceType;
import com.intellij.psi.util.PsiUtil;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.idea.devkit.inspections.quickfix.ChangeToPairCreateQuickFix;
import java.util.Arrays;
/**
* @author Konstantin Bulenkov
*/
@@ -39,10 +39,17 @@ public class DontUseNewPairInspection extends InternalInspection {
@Override
public void visitNewExpression(PsiNewExpression expression) {
final PsiType type = expression.getType();
if (type != null && type.getCanonicalText().startsWith(PAIR_FQN)
final PsiExpressionList params = expression.getArgumentList();
if (type != null && type.getCanonicalText().startsWith(PAIR_FQN) && params != null
&& !(type instanceof PsiArrayType)
&& expression.getText().indexOf('(') > 0
&& type instanceof PsiClassReferenceType
&& !PsiUtil.getLanguageLevel(expression).isAtLeast(LanguageLevel.JDK_1_7)) { //diamonds
holder.registerProblem(expression, "Replace to Pair.create()", ProblemHighlightType.GENERIC_ERROR_OR_WARNING, new ChangeToPairCreateQuickFix());
final PsiType[] types = ((PsiClassReferenceType)type).getParameters();
if (Arrays.equals(types, params.getExpressionTypes())) {
holder.registerProblem(expression, "Replace to Pair.create()", ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
new ChangeToPairCreateQuickFix());
}
}
super.visitNewExpression(expression);
}