MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-92963 Groovy: Good code is red (Invalid value to assign to)

Browse Source
This commit is contained in:
Max Medvedev
2012-10-16 18:01:09 +04:00
parent 3ec3f15f92
commit c13e9f5e3c
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/groovy/src/org/jetbrains/plugins/groovy/lang/psi/util/PsiUtil.java
+7 -2
View File
@@ -69,6 +69,7 @@ import org.jetbrains.plugins.groovy.lang.psi.api.statements.clauses.GrForInClaus
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.*;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.path.GrIndexProperty;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.path.GrMethodCallExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.path.GrPropertySelection;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.params.GrParameter;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.typedef.GrAnonymousClassDefinition;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.typedef.GrTypeDefinition;
@@ -653,8 +654,12 @@ public class PsiUtil {
public static boolean mightBeLValue(@Nullable GrExpression expr) {
if (expr instanceof GrParenthesizedExpression) return mightBeLValue(((GrParenthesizedExpression)expr).getOperand());
if (expr instanceof GrTupleExpression) return true;
if (expr instanceof GrReferenceExpression || expr instanceof GrIndexProperty) return true;
if (expr instanceof GrTupleExpression ||
expr instanceof GrReferenceExpression ||
expr instanceof GrIndexProperty ||
expr instanceof GrPropertySelection) {
return true;
}
if ((expr instanceof GrThisReferenceExpression || expr instanceof GrSuperReferenceExpression) &&
GroovyConfigUtils.getInstance().isVersionAtLeast(expr, GroovyConfigUtils.GROOVY1_8)) {
plugins/groovy/test/org/jetbrains/plugins/groovy/lang/highlighting/GroovyHighlightingTest.groovy
+12
View File
@@ -884,6 +884,18 @@ class X {
}
}
}
''')
}
void testPropertySelectionMayBeLValue() {
testHighlighting('''\
def methodMissing(String methodName, args) {
def closure = {
callSomeOtherMethodInstead()
}
this.metaClass."$methodName" = closure
<error descr="Invalid value to assign to">closure()</error> = 2
}
''')
}
}