MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-32881 Add diagnostics for GUI tests where the exception frequently occurs

Browse Source
This commit is contained in:
Mikhail Golubev
2019-01-28 18:58:55 +03:00
parent cc120e1d48
commit bfe63d93c0
1 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/PythonFoldingBuilder.java
+31
View File
@@ -19,21 +19,27 @@ import com.intellij.codeInsight.folding.CodeFoldingSettings;
import com.intellij.lang.ASTNode;
import com.intellij.lang.folding.CustomFoldingBuilder;
import com.intellij.lang.folding.FoldingDescriptor;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.editor.Document;
import com.intellij.openapi.project.DumbAware;
import com.intellij.openapi.util.Pair;
import com.intellij.openapi.util.TextRange;
import com.intellij.openapi.util.io.StreamUtil;
import com.intellij.openapi.util.text.LineTokenizer;
import com.intellij.openapi.util.text.StringUtil;
import com.intellij.openapi.vfs.CharsetToolkit;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiInvalidElementAccessException;
import com.intellij.psi.PsiWhiteSpace;
import com.intellij.psi.tree.IElementType;
import com.intellij.psi.tree.TokenSet;
import com.intellij.psi.util.PsiUtilCore;
import com.intellij.testFramework.LightVirtualFile;
import com.jetbrains.python.psi.*;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import java.io.IOException;
import java.util.List;
/**
@@ -51,6 +57,9 @@ public class PythonFoldingBuilder extends CustomFoldingBuilder implements DumbAw
PyElementTypes.LIST_COMP_EXPRESSION,
PyElementTypes.TUPLE_EXPRESSION);
private static final Logger LOG = Logger.getInstance(PythonFoldingBuilder.class);
private static final boolean ourUnderGuiTests = System.getenv("GUI_TESTS_RUN") != null;
@Override
protected void buildLanguageFoldRegions(@NotNull List<FoldingDescriptor> descriptors,
@NotNull PsiElement root,
@@ -210,6 +219,8 @@ public class PythonFoldingBuilder extends CustomFoldingBuilder implements DumbAw
if (node.getElementType() == PyElementTypes.STRING_LITERAL_EXPRESSION) {
PyStringLiteralExpression stringLiteralExpression = (PyStringLiteralExpression)node.getPsi();
if (stringLiteralExpression.isDocString()) {
// XXX Remove when it becomes clear why PIEAE happens
checkStringElementsValidityInGuiTests(stringLiteralExpression);
final String stringValue = stringLiteralExpression.getStringValue().trim();
final String[] lines = LineTokenizer.tokenize(stringValue, true);
if (lines.length > 2 && lines[1].trim().length() == 0) {
@@ -223,6 +234,26 @@ public class PythonFoldingBuilder extends CustomFoldingBuilder implements DumbAw
return "...";
}
private static void checkStringElementsValidityInGuiTests(@NotNull PyStringLiteralExpression pyString) {
if (!ourUnderGuiTests) {
return;
}
try {
pyString.getStringElements().forEach(PsiUtilCore::ensureValid);
}
catch (PsiInvalidElementAccessException e) {
LOG.warn(StringUtil.join(e.getAttachments(), a -> {
try {
return a.getName() + "\n" + StreamUtil.readText(a.openContentStream(), CharsetToolkit.UTF8);
}
catch (IOException ignored) {
return "<corrupted stacktrace>";
}
}, "\n\n"), e);
throw e;
}
}
private static String getLanguagePlaceholderForString(PyStringLiteralExpression stringLiteralExpression) {
String stringText = stringLiteralExpression.getText();
Pair<String, String> quotes = PyStringLiteralUtil.getQuotes(stringText);