[PyCharm Tables] (fus, "python.dataview") fixed review remarks

GitOrigin-RevId: 48da962da524ccd1b1772428851cdf87d316e8d9
This commit is contained in:
Natalia.Murycheva
2024-07-10 12:42:36 +02:00
committed by intellij-monorepo-bot
parent d710a02263
commit bf711c1d91
2 changed files with 15 additions and 15 deletions

View File

@@ -190,7 +190,7 @@ open class PyDataViewerPanel(@JvmField protected val project: Project, val frame
}
if (!modifier) {
PyDataViewerCollector.slicingApplied.log()
PyDataViewerCollector.SLICING_APPLIED_EVENT.log()
}
}

View File

@@ -11,7 +11,15 @@ object PyDataViewerCollector : CounterUsagesCollector() {
private val GROUP = EventLogGroup("python.dataview", 3)
enum class DataType(val typeName: String?) {
private val DATA_TYPE_FIELD = EventFields.Enum<DataType>("type")
private val DIMENSIONS_FIELD = EventFields.Enum<DataDimensions>("dimensions")
private val ROWS_COUNT_FIELD = RoundedIntEventField("rows_count")
private val COLUMNS_COUNT_FIELD = RoundedIntEventField("columns_count")
private val DATA_OPENED_EVENT = GROUP.registerVarargEvent("data.opened", DATA_TYPE_FIELD, DIMENSIONS_FIELD, ROWS_COUNT_FIELD, COLUMNS_COUNT_FIELD)
val SLICING_APPLIED_EVENT = GROUP.registerEvent("slicing.applied")
enum class DataType(private val typeName: String?) {
ARRAY("ndarray"),
DATAFRAME("DataFrame"),
GEO_DATAFRAME("GeoDataFrame"),
@@ -51,21 +59,13 @@ object PyDataViewerCollector : CounterUsagesCollector() {
}
}
private val typeField = EventFields.Enum<DataType>("type")
private val dimensionsField = EventFields.Enum<DataDimensions>("dimensions")
private val rowsCountField = RoundedIntEventField("rows_count")
private val columnsCountField = RoundedIntEventField("columns_count")
val dataOpened = GROUP.registerVarargEvent("data.opened", typeField, dimensionsField, rowsCountField, columnsCountField)
val slicingApplied = GROUP.registerEvent("slicing.applied")
override fun getGroup() = GROUP
fun logDataOpened(project: Project?, type: String?, dimensions: Int?, rowsCount: Int, columnsCount: Int) {
dataOpened.log(project, this.typeField.with(DataType.getDataType(type)),
this.dimensionsField.with(DataDimensions.getDataDimensions(dimensions)),
this.rowsCountField.with(rowsCount),
this.columnsCountField.with(columnsCount))
DATA_OPENED_EVENT.log(project,
DATA_TYPE_FIELD.with(DataType.getDataType(type)),
DIMENSIONS_FIELD.with(DataDimensions.getDataDimensions(dimensions)),
ROWS_COUNT_FIELD.with(rowsCount),
COLUMNS_COUNT_FIELD.with(columnsCount))
}
}