lambda effectively final: ignore variables defined inside lambda (IDEA-89818)

java/java-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightControlFlowUtil.java

@@ -694,7 +694,7 @@ public class HighlightControlFlowUtil {
       return highlightInfo;
     }  else {
       final PsiLambdaExpression lambdaExpression = PsiTreeUtil.getParentOfType(context, PsiLambdaExpression.class);
-      if (lambdaExpression != null) {
+      if (lambdaExpression != null && !PsiTreeUtil.isAncestor(lambdaExpression, variable, true)) {
         boolean effectivelyFinal;
         if (variable instanceof PsiParameter) {
           final PsiElement parent = variable.getParent();

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/highlighting/EffectiveFinal.java

@@ -70,3 +70,24 @@ public class XXX {
          foo(() -> <error descr="Variable used in lambda expression should be effectively final">y</error>=1);
      }
 }
+
+class Sample {
+        public static void main(String[] args) {
+                Runnable runnable = () -> {
+                        Integer i;
+                        if (true) {
+                                i = 111;
+                                System.out.println(i);
+                        }
+                };
+
+                Runnable runnable2 = () -> {
+                        Integer i2 = 333;
+                        i2 = 444;
+                        System.out.println(i2);
+                };
+
+                runnable.run();         // prints 111
+                runnable2.run();        // prints 444
+        }
+}