[platform] better ProcessOutput#checkSuccess diagnostic

GitOrigin-RevId: 06077934bcdf25aedbea3ed528dd4801227220c0
This commit is contained in:
Roman Shevchenko
2019-12-27 22:02:24 +00:00
committed by intellij-monorepo-bot
parent 9da22f88db
commit bedaf6c81a
@@ -76,12 +76,21 @@ public class ProcessOutput {
* @param logger where to put error information
* @return true iff exit code is zero
*/
public boolean checkSuccess(@NotNull final Logger logger) {
if (getExitCode() != 0 || isTimeout()) {
logger.info(getStderr() + (isTimeout()? "\nTimed out" : "\nExit code " + getExitCode()));
return false;
public boolean checkSuccess(@NotNull Logger logger) {
int ec = getExitCode();
if (ec == 0 && !isTimeout()) {
return true;
}
return true;
logger.info(isTimeout() ? "Timed out" : "Exit code " + ec);
String output = getStderr();
if (output.isEmpty()) output = getStdout();
if (!output.isEmpty()) {
logger.info(output);
}
return false;
}
public void setExitCode(int exitCode) {