MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fix false positive in format inspection: check compatibility for primitive types only

Browse Source
This commit is contained in:
Valentina Kiryushkina
2017-05-15 14:37:52 +03:00
parent 5e80a61f24
commit bea228fcd7
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyStringFormatInspection.java
+4 -11
View File
@@ -449,10 +449,9 @@ public class PyStringFormatInspection extends PyInspection {
}
}
private int inspectNewStyleArgumentForChunk(int i,
@NotNull PyStringFormatParser.NewStyleSubstitutionChunk chunk,
@NotNull String mappingKey, @NotNull PyStringLiteralExpression formatExpression) {
int arguments = 0;
private void inspectNewStyleArgumentForChunk(int i,
@NotNull PyStringFormatParser.NewStyleSubstitutionChunk chunk,
@NotNull String mappingKey, @NotNull PyStringLiteralExpression formatExpression) {
final PsiElement resolve = new PySubstitutionChunkReference(formatExpression, chunk, i).resolve();
if (resolve == null) {
final String chunkMapping = chunk.getMappingKey();
@@ -476,9 +475,7 @@ public class PyStringFormatInspection extends PyInspection {
}
}
}
arguments++;
}
return arguments;
}
private String inspectNewStyleChunk(@NotNull PyStringLiteralExpression formatExpression,
@@ -607,11 +604,7 @@ public class PyStringFormatInspection extends PyInspection {
final PyStringLiteralExpression literalExpression = PsiTreeUtil.getChildOfType(callee, PyStringLiteralExpression.class);
if (literalExpression != null) {
final Inspection inspection = new Inspection(this, myTypeEvalContext);
final PyArgumentList list = node.getArgumentList();
if (list != null) {
inspection.inspectNewStyleValues(literalExpression);
}
inspection.inspectNewStyleValues(literalExpression);
}
}
}