MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

OverflowingLoopInspection: do not highlight in case of -=- 1

Browse Source
This commit is contained in:
Roman.Ivanov
2019-04-02 10:05:11 +07:00
parent 4ba1315514
commit be87aa1df8
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInspection/OverflowingLoopIndexInspection.java
+2 -2
View File
@@ -135,9 +135,9 @@ public class OverflowingLoopIndexInspection extends AbstractBaseJavaLocalInspect
boolean negative = number.longValue() < 0;
IElementType op = assignment.getOperationTokenType();
if (conditionType == ConditionType.VarGreater) {
return op == JavaTokenType.PLUSEQ || (op == JavaTokenType.MINUSEQ && negative);
return (op == JavaTokenType.PLUSEQ && !negative) || (op == JavaTokenType.MINUSEQ && negative);
} else {
return op == JavaTokenType.MINUSEQ || (op == JavaTokenType.PLUSEQ && negative);
return (op == JavaTokenType.MINUSEQ && !negative) || (op == JavaTokenType.PLUSEQ && negative);
}
}
return false;
java/java-tests/testData/inspection/overflowingLoop/OverflowingLoop.java
+7 -1
View File
@@ -30,7 +30,7 @@ public class OverflowingLoop {
}
void minusEqAddNegative(int s) {
<warning descr="Loop executes zero or billions times">for</warning> (int i = s; i > 12; i += -12) {
for (int i = s; i > 12; i += -12) {
System.out.println(i + 23);
}
}
@@ -61,4 +61,10 @@ public class OverflowingLoop {
i+= 100;
}
}
void minusEqMinus(int s) {
for (int i = 0; i < 10; i -=- 1) {
System.out.println("asdsakdj");
}
}
}