mirror of
https://gitflic.ru/project/openide/openide.git
synced 2026-09-27 10:03:11 +07:00
don't suggest to replace qualifier with import if not accessible (IDEA-188061)
This commit is contained in:
+13
@@ -508,6 +508,19 @@ package com.rocket.test;
|
||||
assert myFixture.filterAvailableIntentions('Replace qualified name').isEmpty()
|
||||
}
|
||||
|
||||
void "test do not allow to add import on inaccessible class"() {
|
||||
myFixture.addClass("package foo; class Foo {}")
|
||||
myFixture.configureByText 'A.java', '''
|
||||
package a;
|
||||
/**
|
||||
* {@link foo.Fo<caret>o}
|
||||
*/
|
||||
class A {}
|
||||
'''
|
||||
myFixture.enableInspections(new UnnecessaryFullyQualifiedNameInspection())
|
||||
assert myFixture.filterAvailableIntentions('Replace qualified name').isEmpty()
|
||||
}
|
||||
|
||||
|
||||
void "test keep methods formatting on add import"() {
|
||||
settings.getCommonSettings(JavaLanguage.INSTANCE).ALIGN_GROUP_FIELD_DECLARATIONS = true
|
||||
|
||||
+4
@@ -259,6 +259,7 @@ public class UnnecessaryFullyQualifiedNameInspection extends BaseInspection impl
|
||||
collectInnerClassNames(reference, references);
|
||||
}
|
||||
Collections.reverse(references);
|
||||
PsiResolveHelper resolveHelper = JavaPsiFacade.getInstance(containingFile.getProject()).getResolveHelper();
|
||||
for (final PsiJavaCodeReferenceElement aReference : references) {
|
||||
final PsiElement referenceTarget = aReference.resolve();
|
||||
if (!(referenceTarget instanceof PsiClass)) {
|
||||
@@ -269,6 +270,9 @@ public class UnnecessaryFullyQualifiedNameInspection extends BaseInspection impl
|
||||
if (qualifiedName == null) {
|
||||
continue;
|
||||
}
|
||||
if (!resolveHelper.isAccessible(aClass, containingFile, null)) {
|
||||
continue;
|
||||
}
|
||||
if (!ImportUtils.nameCanBeImported(qualifiedName, reference)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user