MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 13:02:30 +07:00
Code Issues Packages Projects Releases Wiki Activity

lambda -> method ref: avoid Object::getClass as the type depends on qualifier (IDEA-150967)

Browse Source
This commit is contained in:
Anna Kozlova
2016-02-01 16:02:12 +03:00
parent 7bbd70e695
commit bd2113b739
3 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-analysis-impl/src/com/intellij/codeInspection/LambdaCanBeMethodReferenceInspection.java
View File

@@ -426,7 +426,7 @@ public class LambdaCanBeMethodReferenceInspection extends BaseJavaBatchLocalInsp
return getClassReferenceName(nonAmbiguousContainingClass);
}
if (containingClass.isPhysical() && qualifierExpression instanceof PsiReferenceExpression) {
if (containingClass.isPhysical() && qualifierExpression instanceof PsiReferenceExpression && !PsiTypesUtil.isGetClass(psiMethod)) {
final PsiElement resolve = ((PsiReferenceExpression)qualifierExpression).resolve();
final boolean parameterWithoutFormalType = resolve instanceof PsiParameter && ((PsiParameter)resolve).getTypeElement() == null;
if (parameterWithoutFormalType && ArrayUtil.find(parameters, resolve) > -1) {

13
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/lambda2methodReference/afterGetClaaSpecific.java Normal file
View File

@@ -0,0 +1,13 @@
// "Replace lambda with method reference" "true"
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Function;
import java.util.stream.Stream;
class Test {
public <T> void some(Stream<AtomicReference<T>> stream) {
stream.map((Function<AtomicReference<T>, ? extends Class<? extends AtomicReference>>) AtomicReference<T>::getClass);
}
}

12
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/lambda2methodReference/beforeGetClaaSpecific.java Normal file
View File

@@ -0,0 +1,12 @@
// "Replace lambda with method reference" "true"
import java.util.concurrent.atomic.AtomicReference;
import java.util.stream.Stream;
class Test {
public <T> void some(Stream<AtomicReference<T>> stream) {
stream.map(t -> t.getCl<caret>ass());
}
}