MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

github: cleanup

Browse Source 
myLineNumber is already corrected as we use UpToDateLineNumberListener now
This commit is contained in:
Aleksey Pivovarov
2015-11-16 18:41:39 +03:00
parent 4692d75722
commit bcbd2ac002
1 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/github/src/org/jetbrains/plugins/github/GithubShowCommitInBrowserFromAnnotateAction.java
+4 -12
View File
@@ -51,8 +51,7 @@ public class GithubShowCommitInBrowserFromAnnotateAction extends GithubShowCommi
e.getPresentation().setVisible(false);
return;
}
int corrected = eventData.getCorrectedLineNumber();
e.getPresentation().setEnabled(corrected >= 0 && myAnnotation.getLineRevisionNumber(corrected) != null);
e.getPresentation().setEnabled(myLineNumber >= 0 && myAnnotation.getLineRevisionNumber(myLineNumber) != null);
e.getPresentation().setVisible(GithubUtil.isRepositoryOnGitHub(eventData.getRepository()));
}
@@ -63,7 +62,7 @@ public class GithubShowCommitInBrowserFromAnnotateAction extends GithubShowCommi
return;
}
final VcsRevisionNumber revisionNumber = myAnnotation.getLineRevisionNumber(eventData.getCorrectedLineNumber());
final VcsRevisionNumber revisionNumber = myAnnotation.getLineRevisionNumber(myLineNumber);
if (revisionNumber != null) {
openInBrowser(eventData.getProject(), eventData.getRepository(), revisionNumber.asString());
}
@@ -86,7 +85,7 @@ public class GithubShowCommitInBrowserFromAnnotateAction extends GithubShowCommi
return null;
}
return new EventData(project, repository, lineNumber);
return new EventData(project, repository);
}
@Override
@@ -97,12 +96,10 @@ public class GithubShowCommitInBrowserFromAnnotateAction extends GithubShowCommi
private static class EventData {
@NotNull private final Project myProject;
@NotNull private final GitRepository myRepository;
private final int myCorrectedLineNumber;
private EventData(@NotNull Project project, @NotNull GitRepository repository, int correctedLineNumber) {
private EventData(@NotNull Project project, @NotNull GitRepository repository) {
myProject = project;
myRepository = repository;
myCorrectedLineNumber = correctedLineNumber;
}
@NotNull
@@ -114,10 +111,5 @@ public class GithubShowCommitInBrowserFromAnnotateAction extends GithubShowCommi
public GitRepository getRepository() {
return myRepository;
}
private int getCorrectedLineNumber() {
return myCorrectedLineNumber;
}
}
}