enable "Double negation" inspection by default

This commit is contained in:
Bas Leijdekkers
2012-09-26 16:24:06 +02:00
parent 1b28450790
commit bc2a8990a0
2 changed files with 8 additions and 3 deletions
@@ -603,7 +603,7 @@
groupKey="group.names.control.flow.issues" enabledByDefault="false" level="WARNING"
implementationClass="com.siyeh.ig.controlflow.DefaultNotLastCaseInSwitchInspection"/>
<localInspection language="JAVA" shortName="DoubleNegation" bundle="com.siyeh.InspectionGadgetsBundle" key="double.negation.display.name"
groupBundle="messages.InspectionsBundle" groupKey="group.names.control.flow.issues" enabledByDefault="false"
groupBundle="messages.InspectionsBundle" groupKey="group.names.control.flow.issues" enabledByDefault="true"
level="WARNING" implementationClass="com.siyeh.ig.controlflow.DoubleNegationInspection"/>
<localInspection language="JAVA" shortName="DuplicateBooleanBranch" bundle="com.siyeh.InspectionGadgetsBundle"
key="duplicate.boolean.branch.display.name" groupBundle="messages.InspectionsBundle"
@@ -1,5 +1,5 @@
/*
* Copyright 2006-2011 Bas Leijdekkers
* Copyright 2006-2012 Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -40,6 +40,11 @@ public class DoubleNegationInspection extends BaseInspection {
return InspectionGadgetsBundle.message("double.negation.problem.descriptor");
}
@Override
public boolean isEnabledByDefault() {
return true;
}
@Nullable
protected InspectionGadgetsFix buildFix(Object... infos) {
return new DoubleNegationFix();
@@ -117,7 +122,7 @@ public class DoubleNegationInspection extends BaseInspection {
registerError(expression);
}
private static boolean isNegation(PsiExpression expression) {
private static boolean isNegation(@Nullable PsiExpression expression) {
expression = ParenthesesUtils.stripParentheses(expression);
if (expression instanceof PsiPrefixExpression) return isNegation((PsiPrefixExpression)expression);
if (expression instanceof PsiPolyadicExpression) return isNegation((PsiPolyadicExpression)expression);