inline: don't flatten multi dimensional array in varargs calls (IDEA-153700)

java/java-impl/src/com/intellij/refactoring/util/InlineUtil.java

@@ -295,6 +295,11 @@ public class InlineUtil {
   }
 
   private static boolean isSafeToFlatten(PsiCall callExpression, PsiMethod oldRefMethod, PsiExpression[] arrayElements) {
+    for (PsiExpression arrayElement : arrayElements) {
+      if (arrayElement instanceof PsiArrayInitializerExpression) {
+        return false;
+      }
+    }
     PsiCall copy = (PsiCall)callExpression.copy();
     PsiExpressionList copyArgumentList = copy.getArgumentList();
     LOG.assertTrue(copyArgumentList != null);

java/java-tests/testData/refactoring/inlineLocal/DontOpenMultidimensionalArrays.java

@@ -0,0 +1,10 @@
+import java.util.Arrays;
+import java.util.List;
+
+class Main {
+
+  public static void main(String[] args) {
+    Object[][] pa<caret>rams = new Object[][]{{""}, {""}};
+    List<Object[]> l1 = Arrays.asList(params);
+  }
+}

java/java-tests/testData/refactoring/inlineLocal/DontOpenMultidimensionalArrays.java.after

@@ -0,0 +1,9 @@
+import java.util.Arrays;
+import java.util.List;
+
+class Main {
+
+  public static void main(String[] args) {
+      List<Object[]> l1 = Arrays.asList(new Object[][]{{""}, {""}});
+  }
+}

java/java-tests/testSrc/com/intellij/refactoring/inline/InlineLocalTest.java

@@ -260,6 +260,10 @@ public class InlineLocalTest extends LightCodeInsightTestCase {
     doTest(true);
   }
 
+  public void testDontOpenMultidimensionalArrays() throws Exception {
+    doTest(false);
+  }
+
   public void testLocalVarInsideLambdaBodyWriteUsage() throws Exception {
     doTest(true, "Cannot perform refactoring.\n" +
                  "Variable 'hello' is accessed for writing");