MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-19 21:11:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java] improve quick-fix text (IDEA-223692)

Browse Source 
GitOrigin-RevId: 7226e492ffe7889bfbabab6dd9ea3d04d64a1d0f
This commit is contained in:
Bas Leijdekkers
2024-03-08 16:26:25 +01:00
committed by intellij-monorepo-bot
parent 8e6fa7b008
commit babfae316e
23 changed files with 29 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/java-analysis-impl/src/messages/QuickFixBundle.properties
View File

@@ -2,9 +2,10 @@ add.import=Add Import
class.to.import.chooser.title=Class to Import
method.to.import.chooser.title=Method to Import
field.to.import.chooser.title=Field to Import
access.static.via.class.reference.family=Access static via class reference
access.static.via.class.reference.title=Access Static via Class Reference
access.static.via.class.reference.text=Access static ''{1}.{0}'' via class ''{2}'' reference
access.static.via.class.reference.family=Qualify static member access with class reference
access.static.via.class.reference.title=Qualify Static Member Access with Class Reference
access.static.method.via.class.reference.text=Qualify static ''{0}'' call with reference to class ''{1}''
access.static.field.via.class.reference.text=Qualify static ''{0}'' access with reference to class ''{1}''
add.default.constructor.family=Add Default Constructor
add.default.constructor.text=Add {0} no-args constructor to {1}
add.catch.clause.family=Add exception to catch clause

7
java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/AccessStaticViaInstanceFix.java
View File

@@ -1,4 +1,4 @@
// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.codeInsight.daemon.impl.quickfix;
import com.intellij.codeInsight.BlockUtils;
@@ -71,9 +71,10 @@ public class AccessStaticViaInstanceFix extends PsiBasedModCommandAction<PsiRefe
private static @IntentionName String calcText(PsiMember member, PsiSubstitutor substitutor) {
PsiClass aClass = member.getContainingClass();
if (aClass == null) return "";
return QuickFixBundle.message("access.static.via.class.reference.text",
return QuickFixBundle.message(member instanceof PsiMethod
? "access.static.method.via.class.reference.text"
: "access.static.field.via.class.reference.text",
HighlightMessageUtil.getSymbolName(member, substitutor, PsiFormatUtilBase.SHOW_TYPE),
HighlightUtil.formatClass(aClass, false),
HighlightUtil.formatClass(aClass, false));
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/after1NoSideEffect.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.fff' via class 'AClass' reference|->Delete possible side effects" "true-preview"
// "Qualify static 'fff' access with reference to class 'AClass'|->Delete possible side effects" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/after1SideEffect.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.fff' via class 'AClass' reference|->Extract possible side effects" "true-preview"
// "Qualify static 'fff' access with reference to class 'AClass'|->Extract possible side effects" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/after2.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.fff' via class 'AClass' reference" "true-preview"
// "Qualify static 'fff' access with reference to class 'AClass'" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/after3.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.getA()' via class 'AClass' reference" "true-preview"
// "Qualify static 'getA()' call with reference to class 'AClass'" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/after5.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.stat' via class 'AClass' reference" "true-preview"
// "Qualify static 'stat' access with reference to class 'AClass'" "true-preview"
class AClass {
static boolean stat;

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/after6SideEffect.java
View File

@@ -1,4 +1,4 @@
// "Access static 'R.rr' via class 'R' reference|->Extract possible side effects" "true-preview"
// "Qualify static 'rr' access with reference to class 'R'|->Extract possible side effects" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/afterAccessForStaticMethodInInterface.java
View File

@@ -1,4 +1,4 @@
// "Access static 'I.m()' via class 'I' reference" "true-preview"
// "Qualify static 'm()' call with reference to class 'I'" "true-preview"
interface I {
static void m() {}
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/afterAccessForStaticMethodInInterface1.java
View File

@@ -1,4 +1,4 @@
// "Access static 'I.m()' via class 'I' reference" "true-preview"
// "Qualify static 'm()' call with reference to class 'I'" "true-preview"
interface I {
static void m() {}
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/afterAccessForStaticMethodInInterfaceNoQualifier.java
View File

@@ -1,4 +1,4 @@
// "Access static 'I.m()' via class 'I' reference" "true-preview"
// "Qualify static 'm()' call with reference to class 'I'" "true-preview"
interface I {
static void m() {}
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/afterPreserveTypeArgs.java
View File

@@ -1,4 +1,4 @@
// "Access static 'Bug.right(B)' via class 'Bug' reference" "true-preview"
// "Qualify static 'right(B)' call with reference to class 'Bug'" "true-preview"
class Bug<A, B> {
public A getLeft() {

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/before1NoSideEffect.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.fff' via class 'AClass' reference|->Delete possible side effects" "true-preview"
// "Qualify static 'fff' access with reference to class 'AClass'|->Delete possible side effects" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/before1SideEffect.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.fff' via class 'AClass' reference|->Extract possible side effects" "true-preview"
// "Qualify static 'fff' access with reference to class 'AClass'|->Extract possible side effects" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/before2.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.fff' via class 'AClass' reference" "true-preview"
// "Qualify static 'fff' access with reference to class 'AClass'" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/before3.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.getA()' via class 'AClass' reference" "true-preview"
// "Qualify static 'getA()' call with reference to class 'AClass'" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/before4.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.R.rr' via class 'AClass.R' reference" "false"
// "Qualify static 'rr' access with reference to class 'AClass.R'" "false"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/before5.java
View File

@@ -1,4 +1,4 @@
// "Access static 'AClass.stat' via class 'AClass' reference" "true-preview"
// "Qualify static 'stat' access with reference to class 'AClass'" "true-preview"
class AClass {
static boolean stat;

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/before6SideEffect.java
View File

@@ -1,4 +1,4 @@
// "Access static 'R.rr' via class 'R' reference|->Extract possible side effects" "true-preview"
// "Qualify static 'rr' access with reference to class 'R'|->Extract possible side effects" "true-preview"
class AClass
{

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/beforeAccessForStaticMethodInInterface.java
View File

@@ -1,4 +1,4 @@
// "Access static 'I.m()' via class 'I' reference" "true-preview"
// "Qualify static 'm()' call with reference to class 'I'" "true-preview"
interface I {
static void m() {}
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/beforeAccessForStaticMethodInInterface1.java
View File

@@ -1,4 +1,4 @@
// "Access static 'I.m()' via class 'I' reference" "true-preview"
// "Qualify static 'm()' call with reference to class 'I'" "true-preview"
interface I {
static void m() {}
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/beforeAccessForStaticMethodInInterfaceNoQualifier.java
View File

@@ -1,4 +1,4 @@
// "Access static 'I.m()' via class 'I' reference" "true-preview"
// "Qualify static 'm()' call with reference to class 'I'" "true-preview"
interface I {
static void m() {}
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/accessStaticViaInstance/beforePreserveTypeArgs.java
View File

@@ -1,4 +1,4 @@
// "Access static 'Bug.right(B)' via class 'Bug' reference" "true-preview"
// "Qualify static 'right(B)' call with reference to class 'Bug'" "true-preview"
class Bug<A, B> {
public A getLeft() {