MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-20 13:31:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

[pycharm] PY-38169 In quick documentation display .py sources as the origin for .pyi declarations

Browse Source 
In particular point that `collection.abc` symbols are defined in _collections_abc.py.


IJ-MR-159943

GitOrigin-RevId: 67e7f402f7bf266e6232aaa05947cb29eed4d9d7
This commit is contained in:
Mikhail Golubev
2025-04-30 16:29:30 +03:00
committed by intellij-monorepo-bot
parent d84eda6a48
commit b91099d758
5 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
python/python-psi-impl/src/com/jetbrains/python/documentation/PyDocumentationBuilder.java
View File

@@ -372,7 +372,8 @@ public final class PyDocumentationBuilder {
final PyStringLiteralExpression effectiveDocstring = modifyDocStringByOwnerType(ownDocstring, elementDefinition, isProperty);
if (PyUtil.isTopLevel(elementDefinition)) {
final PsiFile containing = elementDefinition.getContainingFile();
final PsiFile containing = ObjectUtils.chooseNotNull(PyiUtil.getOriginalElement(elementDefinition),
elementDefinition).getContainingFile();
if (containing instanceof PyFile) {
final HtmlChunk linkToModule = getLinkToModule((PyFile)containing);
if (linkToModule != null) {

1
python/testData/quickdoc/DefinitionWrongInTypeshed.html
View File

@@ -1 +0,0 @@
<html><body><div class="bottom"><icon src="AllIcons.Nodes.Package"/>&nbsp;<code><a href="psi_element://#module#typing">typing</a></code></div><div class="definition"><pre><span style="color:#000080;font-weight:bold;">class </span><span style="color:#000000;">Mapping</span><span style="">(</span><a href="psi_element://#typename#typing.Collection">Collection</a><span style="">[</span>_KT<span style="">]</span><span style="">, </span>Generic<span style="">[</span>_KT, _VT_co<span style="">]</span><span style="">)</span></pre></div></body></html>

1
python/testData/quickdoc/UnderscoreCollectionsAbcSymbolRealOrigin.html Normal file
View File

@@ -0,0 +1 @@
<html><body><div class="bottom"><icon src="AllIcons.Nodes.Package"/>&nbsp;<code><a href="psi_element://#module#_collections_abc">_collections_abc</a></code></div><div class="definition"><pre><span style="color:#000080;font-weight:bold;">class </span><span style="color:#000000;">Mapping</span><span style="">(</span><a href="psi_element://#typename#typing.Collection">Collection</a><span style="">[</span>_KT<span style="">]</span><span style="">, </span>Generic<span style="">[</span>_KT, _VT_co<span style="">]</span><span style="">)</span></pre></div></body></html>

0
python/testData/quickdoc/DefinitionWrongInTypeshed.py → python/testData/quickdoc/UnderscoreCollectionsAbcSymbolRealOrigin.py
View File

7
python/testSrc/com/jetbrains/python/Py3QuickDocTest.java
View File

@@ -866,9 +866,10 @@ public class Py3QuickDocTest extends LightMarkedTestCase {
}
// PY-38169
public void testDefinitionWrongInTypeshed() {
// TODO: PY-80728, this test contains _some_ invalid output
checkHTMLOnly();
public void testUnderscoreCollectionsAbcSymbolRealOrigin() {
runWithAdditionalFileInLibDir("_collections_abc.py", "class Mapping: ...", ignored -> {
checkHTMLOnly();
});
}
@Override