MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

(no message)

Browse Source
This commit is contained in:
Dave Griffith
2005-03-15 19:49:25 +03:00
parent 488d1398e2
commit b8425ffed4
54 changed files with 82 additions and 540 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/BaseInspectionVisitor.java
-12
View File
@@ -24,18 +24,6 @@ public abstract class BaseInspectionVisitor extends PsiRecursiveElementVisitor{
m_onTheFly = onTheFly;
}
public void visitReferenceExpression(PsiReferenceExpression expression){
final PsiExpression qualifier = expression.getQualifierExpression();
if(qualifier != null){
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters =
expression.getParameterList();
if(typeParameters != null){
typeParameters.accept(this);
}
}
protected void registerMethodCallError(PsiMethodCallExpression expression){
final PsiReferenceExpression methodExpression =
expression.getMethodExpression();
plugins/InspectionGadgets/src/com/siyeh/ig/abstraction/ClassAccessVisitor.java
-11
View File
@@ -18,17 +18,6 @@ class ClassAccessVisitor extends PsiRecursiveElementVisitor {
this.currentClass = currentClass;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression expression) {
super.visitMethodCallExpression(expression);
final PsiMethod method = expression.resolveMethod();
plugins/InspectionGadgets/src/com/siyeh/ig/abstraction/InstanceofChainInspection.java
+1 -1
View File
@@ -18,7 +18,7 @@ public class InstanceofChainInspection extends StatementInspection {
}
protected String buildErrorString(PsiElement location) {
return "Chain of 'instanceof' checks indicates abstraction faiulre #loc";
return "Chain of 'instanceof' checks indicates abstraction failure #loc";
}
public BaseInspectionVisitor createVisitor(InspectionManager inspectionManager, boolean onTheFly) {
plugins/InspectionGadgets/src/com/siyeh/ig/bugs/CollectionQueryCalledVisitor.java
-10
View File
@@ -39,16 +39,6 @@ public class CollectionQueryCalledVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression exp) {
final PsiExpression qualifier = exp.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = exp.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitForeachStatement(PsiForeachStatement statement) {
super.visitForeachStatement(statement);
plugins/InspectionGadgets/src/com/siyeh/ig/bugs/CollectionUpdateCalledVisitor.java
-10
View File
@@ -36,16 +36,6 @@ public class CollectionUpdateCalledVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression exp) {
final PsiExpression qualifier = exp.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = exp.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression call) {
super.visitMethodCallExpression(call);
plugins/InspectionGadgets/src/com/siyeh/ig/bugs/FloatingPointEqualityInspection.java
+2 -2
View File
@@ -50,10 +50,10 @@ public class FloatingPointEqualityInspection extends ExpressionInspection {
return;
}
final PsiExpression rhs = expression.getROperand();
if(!isFloatingPointType(rhs)){
if(isFloatingPointType(rhs)){
registerError(expression);
return;
}
registerError(expression);
}
private static boolean isFloatingPointType(PsiExpression expression) {
plugins/InspectionGadgets/src/com/siyeh/ig/bugs/ForLoopThatDoesntUseLoopVariableInspection.java
+1 -8
View File
@@ -140,14 +140,7 @@ public class ForLoopThatDoesntUseLoopVariableInspection extends StatementInspect
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(ref);
final PsiElement resolvedElement = ref.resolve();
if (m_variable.equals(resolvedElement)) {
m_used = true;
plugins/InspectionGadgets/src/com/siyeh/ig/bugs/InstanceofIncompatibleInterfaceInspection.java
+4 -1
View File
@@ -4,6 +4,8 @@ import com.intellij.codeInspection.InspectionManager;
import com.intellij.psi.*;
import com.intellij.psi.search.PsiSearchHelper;
import com.intellij.psi.search.SearchScope;
import com.intellij.psi.search.GlobalSearchScope;
import com.intellij.openapi.project.Project;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.ExpressionInspection;
@@ -94,8 +96,9 @@ public class InstanceofIncompatibleInterfaceInspection extends ExpressionInspect
return true;
}
final PsiManager psiManager = aClass.getManager();
final Project project = psiManager.getProject();
final PsiSearchHelper searchHelper = psiManager.getSearchHelper();
final SearchScope searchScope = aClass.getUseScope();
final SearchScope searchScope = GlobalSearchScope.allScope(project);
final PsiClass[] inheritors =
searchHelper.findInheritors(aClass, searchScope, true);
for(int i = 0; i < inheritors.length; i++){
plugins/InspectionGadgets/src/com/siyeh/ig/classmetrics/ComplexityVisitor.java
-11
View File
@@ -5,17 +5,6 @@ import com.intellij.psi.*;
class ComplexityVisitor extends PsiRecursiveElementVisitor {
private int m_complexity = 1;
public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if(qualifier!=null){
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = expression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAnonymousClass(PsiAnonymousClass aClass) {
// to call to super, to keep this from drilling down
}
plugins/InspectionGadgets/src/com/siyeh/ig/classmetrics/CouplingVisitor.java
-11
View File
@@ -110,17 +110,6 @@ class CouplingVisitor extends PsiRecursiveElementVisitor {
}
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitTryStatement(PsiTryStatement statement) {
super.visitTryStatement(statement);
final PsiParameter[] catchBlockParameters = statement.getCatchBlockParameters();
plugins/InspectionGadgets/src/com/siyeh/ig/cloneable/CallToSuperCloneVisitor.java
-11
View File
@@ -25,17 +25,6 @@ class CallToSuperCloneVisitor extends PsiRecursiveElementVisitor {
m_callToSuperCloneFound = true;
}
public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = expression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public boolean isCallToSuperCloneFound() {
return m_callToSuperCloneFound;
}
plugins/InspectionGadgets/src/com/siyeh/ig/confusing/ImplicitNumericConversionInspection.java
+9
View File
@@ -197,6 +197,15 @@ public class ImplicitNumericConversionInspection extends ExpressionInspection {
public void visitExpression(PsiExpression exp) {
super.visitExpression(exp);
checkExpression(exp);
}
public void visitReferenceExpression(PsiReferenceExpression expression){
super.visitReferenceExpression(expression);
checkExpression(expression);
}
private void checkExpression(PsiExpression exp){
final PsiElement parent = exp.getParent();
if(parent!=null && parent instanceof PsiParenthesizedExpression)
{
plugins/InspectionGadgets/src/com/siyeh/ig/confusing/LocalVariableAccessVisitor.java
+1 -8
View File
@@ -14,15 +14,8 @@ class LocalVariableAccessVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
super.visitReferenceExpression(ref);
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
if (qualifier != null && !(qualifier instanceof PsiThisExpression)) {
return;
}
plugins/InspectionGadgets/src/com/siyeh/ig/confusing/RefusedBequestInspection.java
-10
View File
@@ -79,16 +79,6 @@ public class RefusedBequestInspection extends MethodInspection {
this.methodToSearchFor = methodToSearchFor;
}
public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = expression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression expression) {
super.visitMethodCallExpression(expression);
plugins/InspectionGadgets/src/com/siyeh/ig/confusing/SwitchStatementDensityInspection.java
-11
View File
@@ -74,17 +74,6 @@ public class SwitchStatementDensityInspection extends StatementInspection {
private static class StatementCountVisitor extends PsiRecursiveElementVisitor {
private int numStatements = 0;
public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = expression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitStatement(PsiStatement psiStatement) {
super.visitStatement(psiStatement);
numStatements++;
plugins/InspectionGadgets/src/com/siyeh/ig/errorhandling/CatchParameterUsedVisitor.java
+1 -8
View File
@@ -12,14 +12,7 @@ public class CatchParameterUsedVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression reference) {
final PsiExpression qualifier = reference.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = reference.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(reference);
final PsiElement element = reference.resolve();
if (m_parameter.equals(element)) {
m_used = true;
plugins/InspectionGadgets/src/com/siyeh/ig/finalization/CallToSuperFinalizeVisitor.java
-10
View File
@@ -25,16 +25,6 @@ class CallToSuperFinalizeVisitor extends PsiRecursiveElementVisitor {
m_callToSuperFinalizeFound = true;
}
public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = expression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public boolean isCallToSuperFinalizeFound() {
return m_callToSuperFinalizeFound;
plugins/InspectionGadgets/src/com/siyeh/ig/imports/ImportIsUsedVisitor.java
+1 -8
View File
@@ -17,14 +17,7 @@ class ImportIsUsedVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(ref);
followReferenceToImport(ref);
}
plugins/InspectionGadgets/src/com/siyeh/ig/jdk/AutoBoxingInspection.java
+19 -6
View File
@@ -6,9 +6,10 @@ import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiExpression;
import com.intellij.psi.PsiType;
import com.intellij.psi.PsiReferenceExpression;
import com.siyeh.ig.*;
import com.siyeh.ig.psiutils.ClassUtils;
import com.siyeh.ig.psiutils.ExpectedTypeUtils;
import com.siyeh.ig.psiutils.ClassUtils;
import java.util.HashMap;
import java.util.Map;
@@ -76,26 +77,38 @@ public class AutoBoxingInspection extends ExpressionInspection {
super(inspection, inspectionManager, isOnTheFly);
}
public void visitReferenceExpression(PsiReferenceExpression expression){
super.visitReferenceExpression(expression);
checkExpression(expression);
}
public void visitExpression(PsiExpression expression) {
super.visitExpression(expression);
checkExpression(expression);
}
private void checkExpression(PsiExpression expression)
{
final PsiType expressionType = expression.getType();
if (expressionType == null) {
if(expressionType == null){
return;
}
if (!ClassUtils.isPrimitive(expressionType)) {
if(!ClassUtils.isPrimitive(expressionType)){
return;
}
final PsiType expectedType = ExpectedTypeUtils.findExpectedType(expression);
if (expectedType == null) {
final PsiType expectedType =
ExpectedTypeUtils.findExpectedType(expression);
if(expectedType == null){
return;
}
if (ClassUtils.isPrimitive(expectedType)) {
if(ClassUtils.isPrimitive(expectedType)){
return;
}
registerError(expression);
}
}
}
plugins/InspectionGadgets/src/com/siyeh/ig/jdk/AutoUnboxingInspection.java
+26 -12
View File
@@ -6,10 +6,11 @@ import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiExpression;
import com.intellij.psi.PsiType;
import com.intellij.psi.PsiReferenceExpression;
import com.siyeh.ig.*;
import com.siyeh.ig.psiutils.ClassUtils;
import com.siyeh.ig.psiutils.ExpectedTypeUtils;
import com.siyeh.ig.psiutils.TypeUtils;
import com.siyeh.ig.psiutils.ClassUtils;
import java.util.HashMap;
import java.util.HashSet;
@@ -21,7 +22,7 @@ public class AutoUnboxingInspection extends ExpressionInspection {
private static final Set s_numberTypes = new HashSet(8);
private final AutoUnboxingFix fix = new AutoUnboxingFix();
static {
static {
s_unboxingMethods.put("int", "intValue");
s_unboxingMethods.put("short", "shortValue");
s_unboxingMethods.put("boolean", "booleanValue");
@@ -66,7 +67,9 @@ public class AutoUnboxingInspection extends ExpressionInspection {
}
public void applyFix(Project project, ProblemDescriptor descriptor) {
if(isQuickFixOnReadOnlyFile(project, descriptor)) return;
if(isQuickFixOnReadOnlyFile(project, descriptor)){
return;
}
final PsiExpression expression = (PsiExpression) descriptor.getPsiElement();
final PsiType type = expression.getType();
@@ -93,28 +96,39 @@ public class AutoUnboxingInspection extends ExpressionInspection {
public void visitExpression(PsiExpression expression) {
super.visitExpression(expression);
checkExpression(expression);
}
public void visitReferenceExpression(PsiReferenceExpression expression){
super.visitReferenceExpression(expression);
checkExpression(expression);
}
public void checkExpression(PsiExpression expression) {
final PsiType expressionType = expression.getType();
if (expressionType == null) {
if(expressionType == null){
return;
}
if(expressionType.getArrayDimensions()>0)
{
if(expressionType.getArrayDimensions() > 0){
return; // a horrible hack to get around what happens when you pass an array to a vararg expression
}
if (ClassUtils.isPrimitive(expressionType)) {
return;
}
final PsiType expectedType = ExpectedTypeUtils.findExpectedType(expression);
if (expectedType == null) {
if(ClassUtils.isPrimitive(expressionType)){
return;
}
final PsiType expectedType =
ExpectedTypeUtils.findExpectedType(expression);
if (!ClassUtils.isPrimitive(expectedType)) {
if(expectedType == null){
return;
}
if(!ClassUtils.isPrimitive(expectedType)){
return;
}
registerError(expression);
}
}
}
plugins/InspectionGadgets/src/com/siyeh/ig/junit/CallToSuperSetupVisitor.java
-11
View File
@@ -25,17 +25,6 @@ class CallToSuperSetupVisitor extends PsiRecursiveElementVisitor {
m_callToSuperSetupFound = true;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public boolean isCallToSuperSetupFound() {
return m_callToSuperSetupFound;
}
plugins/InspectionGadgets/src/com/siyeh/ig/junit/CallToSuperTeardownVisitor.java
-11
View File
@@ -25,17 +25,6 @@ class CallToSuperTeardownVisitor extends PsiRecursiveElementVisitor {
m_callToSuperTeardownFound = true;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public boolean isCallToSuperTeardownFound() {
return m_callToSuperTeardownFound;
}
plugins/InspectionGadgets/src/com/siyeh/ig/methodmetrics/CouplingVisitor.java
-11
View File
@@ -90,17 +90,6 @@ class CouplingVisitor extends PsiRecursiveElementVisitor {
}
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitTryStatement(PsiTryStatement statement) {
super.visitTryStatement(statement);
final PsiParameter[] catchBlockParameters = statement.getCatchBlockParameters();
plugins/InspectionGadgets/src/com/siyeh/ig/methodmetrics/CyclomaticComplexityVisitor.java
-10
View File
@@ -5,16 +5,6 @@ import com.intellij.psi.*;
class CyclomaticComplexityVisitor extends PsiRecursiveElementVisitor {
private int m_complexity = 1;
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
} }
public void visitAnonymousClass(PsiAnonymousClass aClass) {
// to call to super, to keep this from drilling down
}
plugins/InspectionGadgets/src/com/siyeh/ig/methodmetrics/LoopCountVisitor.java
-10
View File
@@ -5,16 +5,6 @@ import com.intellij.psi.*;
class LoopCountVisitor extends PsiRecursiveElementVisitor {
private int m_count = 0;
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitForStatement(PsiForStatement psiForStatement) {
super.visitForStatement(psiForStatement);
plugins/InspectionGadgets/src/com/siyeh/ig/methodmetrics/NCSSVisitor.java
-11
View File
@@ -5,17 +5,6 @@ import com.intellij.psi.*;
class NCSSVisitor extends PsiRecursiveElementVisitor {
private int m_statementCount = 0;
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAnonymousClass(PsiAnonymousClass aClass) {
// to call to super, to keep this from drilling down
}
plugins/InspectionGadgets/src/com/siyeh/ig/methodmetrics/NegationCountVisitor.java
-11
View File
@@ -6,17 +6,6 @@ import com.intellij.psi.tree.IElementType;
class NegationCountVisitor extends PsiRecursiveElementVisitor {
private int m_count = 0;
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitBinaryExpression(PsiBinaryExpression expression) {
super.visitBinaryExpression(expression);
final PsiJavaToken sign = expression.getOperationSign();
plugins/InspectionGadgets/src/com/siyeh/ig/methodmetrics/NestingDepthVisitor.java
-9
View File
@@ -6,15 +6,6 @@ class NestingDepthVisitor extends PsiRecursiveElementVisitor {
private int m_maximumDepth = 0;
private int m_currentDepth = 0;
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
} }
public void visitAnonymousClass(PsiAnonymousClass aClass) {
// to call to super, to keep this from drilling down
plugins/InspectionGadgets/src/com/siyeh/ig/methodmetrics/ReturnPointCountVisitor.java
-10
View File
@@ -5,16 +5,6 @@ import com.intellij.psi.*;
class ReturnPointCountVisitor extends PsiRecursiveElementVisitor {
private int m_count = 0;
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAnonymousClass(PsiAnonymousClass aClass) {
// no call to super, to keep it from drilling into anonymous classes
plugins/InspectionGadgets/src/com/siyeh/ig/performance/CanBeStaticVisitor.java
+1 -8
View File
@@ -10,14 +10,7 @@ class CanBeStaticVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(ref);
final PsiElement element = ref.resolve();
if (element instanceof PsiField) {
final PsiField field = (PsiField) element;
plugins/InspectionGadgets/src/com/siyeh/ig/performance/InnerClassReferenceVisitor.java
+2 -7
View File
@@ -65,14 +65,9 @@ class InnerClassReferenceVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression referenceExpression) {
super.visitReferenceExpression(referenceExpression);
final PsiExpression qualifier = referenceExpression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = referenceExpression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
if (qualifier instanceof PsiSuperExpression) {
return;
plugins/InspectionGadgets/src/com/siyeh/ig/performance/MethodReferenceVisitor.java
+2 -8
View File
@@ -37,14 +37,8 @@ class MethodReferenceVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = expression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(expression);
final PsiElement element = expression.resolve();
if (element instanceof PsiField) {
m_referencesStaticallyAccessible &= isFieldStaticallyAccessible((PsiField) element);
plugins/InspectionGadgets/src/com/siyeh/ig/performance/StringVariableIsAppendedToVisitor.java
-11
View File
@@ -12,17 +12,6 @@ public class StringVariableIsAppendedToVisitor extends PsiRecursiveElementVisito
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression referenceExpression) {
final PsiExpression qualifier = referenceExpression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = referenceExpression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAssignmentExpression(PsiAssignmentExpression assignment) {
super.visitAssignmentExpression(assignment);
final PsiExpression lhs = assignment.getLExpression();
plugins/InspectionGadgets/src/com/siyeh/ig/performance/VariableAccessVisitor.java
+2 -7
View File
@@ -16,14 +16,9 @@ class VariableAccessVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
super.visitReferenceExpression(ref);
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
if (qualifier != null && !(qualifier instanceof PsiThisExpression)) {
return;
}
plugins/InspectionGadgets/src/com/siyeh/ig/performance/VariableIsModifiedVisitor.java
-10
View File
@@ -11,16 +11,6 @@ public class VariableIsModifiedVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression call) {
super.visitMethodCallExpression(call);
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/ArrayContentsAccessedVisitor.java
-11
View File
@@ -11,17 +11,6 @@ public class ArrayContentsAccessedVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitForeachStatement(PsiForeachStatement statement) {
super.visitForeachStatement(statement);
final PsiExpression qualifier = statement.getIteratedValue();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/ArrayContentsAssignedVisitor.java
-11
View File
@@ -11,17 +11,6 @@ public class ArrayContentsAssignedVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAssignmentExpression(PsiAssignmentExpression assignment) {
super.visitAssignmentExpression(assignment);
final PsiJavaToken operationSign = assignment.getOperationSign();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/ControlFlowUtils.java
-9
View File
@@ -340,9 +340,6 @@ public class ControlFlowUtils {
// do nothing, to keep drilling into inner classes
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
}
public void visitReturnStatement(PsiReturnStatement returnStatement) {
super.visitReturnStatement(returnStatement);
m_found = true;
@@ -362,9 +359,6 @@ public class ControlFlowUtils {
return m_found;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
}
public void visitBreakStatement(PsiBreakStatement breakStatement) {
super.visitBreakStatement(breakStatement);
final PsiStatement exitedStatement = breakStatement.findExitedStatement();
@@ -392,9 +386,6 @@ public class ControlFlowUtils {
return m_found;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
}
public void visitContinueStatement(PsiContinueStatement statement) {
super.visitContinueStatement(statement);
final PsiIdentifier labelIdentifier = statement.getLabelIdentifier();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/ExceptionUtils.java
-4
View File
@@ -55,10 +55,6 @@ public class ExceptionUtils {
m_factory = factory;
}
public void visitReferenceExpression(PsiReferenceExpression expression) {
}
public void visitMethodCallExpression(PsiMethodCallExpression expression) {
super.visitMethodCallExpression(expression);
final PsiMethod method = expression.resolveMethod();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/ImportUtils.java
-10
View File
@@ -132,16 +132,6 @@ public class ImportUtils {
this.fullyQualifiedName = fullyQualifiedName;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitReferenceElement(PsiJavaCodeReferenceElement ref) {
final String text = ref.getText();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/RecursionVisitor.java
-11
View File
@@ -11,17 +11,6 @@ public class RecursionVisitor extends PsiRecursiveElementVisitor {
m_method = method;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression psiMethodCallExpression) {
super.visitMethodCallExpression(psiMethodCallExpression);
final PsiMethod method = psiMethodCallExpression.resolveMethod();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/SideEffectChecker.java
-10
View File
@@ -22,16 +22,6 @@ public class SideEffectChecker {
return m_mayHaveSideEffects;
}
public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = expression.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAssignmentExpression(PsiAssignmentExpression expression) {
super.visitAssignmentExpression(expression);
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/VariableAssignedFromVisitor.java
-11
View File
@@ -11,17 +11,6 @@ public class VariableAssignedFromVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAssignmentExpression(PsiAssignmentExpression assignment) {
super.visitAssignmentExpression(assignment);
final PsiExpression arg = assignment.getRExpression();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/VariableAssignedVisitor.java
+1 -12
View File
@@ -12,17 +12,6 @@ public class VariableAssignedVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAssignmentExpression(PsiAssignmentExpression assignment) {
super.visitAssignmentExpression(assignment);
final PsiExpression arg = assignment.getLExpression();
@@ -62,7 +51,7 @@ public class VariableAssignedVisitor extends PsiRecursiveElementVisitor {
assigned = true;
}
}
public void visitPostfixExpression(PsiPostfixExpression postfixExpression) {
super.visitPostfixExpression(postfixExpression);
final PsiJavaToken operationSign = postfixExpression.getOperationSign();
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/VariablePassedAsArgumentVisitor.java
-10
View File
@@ -11,16 +11,6 @@ public class VariablePassedAsArgumentVisitor extends PsiRecursiveElementVisitor
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression call) {
super.visitMethodCallExpression(call);
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/VariableReturnedVisitor.java
-10
View File
@@ -11,16 +11,6 @@ public class VariableReturnedVisitor extends PsiRecursiveElementVisitor {
this.variable = variable;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitReturnStatement(PsiReturnStatement returnStatement) {
super.visitReturnStatement(returnStatement);
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/VariableUsedInInnerClassVisitor.java
+2 -8
View File
@@ -20,14 +20,8 @@ public class VariableUsedInInnerClassVisitor extends PsiRecursiveElementVisitor
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(ref);
if (!m_inInnerClass) {
return;
}
plugins/InspectionGadgets/src/com/siyeh/ig/psiutils/VariableUsedVisitor.java
+2 -8
View File
@@ -12,14 +12,8 @@ public class VariableUsedVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(ref);
final PsiElement referent = ref.resolve();
if (referent == null) {
return;
plugins/InspectionGadgets/src/com/siyeh/ig/resources/IOResourceInspection.java
-24
View File
@@ -134,18 +134,6 @@ public class IOResourceInspection extends ExpressionInspection{
this.streamToClose = streamToClose;
}
public void visitReferenceExpression(PsiReferenceExpression ref){
final PsiExpression qualifier = ref.getQualifierExpression();
if(qualifier != null){
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters =
ref.getParameterList();
if(typeParameters != null){
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression call){
super.visitMethodCallExpression(call);
final PsiReferenceExpression methodExpression =
@@ -187,18 +175,6 @@ public class IOResourceInspection extends ExpressionInspection{
this.ioResource = streamToClose;
}
public void visitReferenceExpression(PsiReferenceExpression ref){
final PsiExpression qualifier = ref.getQualifierExpression();
if(qualifier != null){
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters =
ref.getParameterList();
if(typeParameters != null){
typeParameters.accept(this);
}
}
public void visitNewExpression(PsiNewExpression expression){
super.visitNewExpression(expression);
if(!isIOResource(expression)){
plugins/InspectionGadgets/src/com/siyeh/ig/resources/JDBCResourceInspection.java
-11
View File
@@ -124,17 +124,6 @@ public class JDBCResourceInspection extends ExpressionInspection {
this.streamToClose = streamToClose;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression call) {
super.visitMethodCallExpression(call);
final PsiReferenceExpression methodExpression = call.getMethodExpression();
plugins/InspectionGadgets/src/com/siyeh/ig/threading/VariableAccessVisitor.java
+2 -7
View File
@@ -16,14 +16,9 @@ class VariableAccessVisitor extends PsiRecursiveElementVisitor {
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
super.visitReferenceExpression(ref);
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
if (qualifier != null && !(qualifier instanceof PsiThisExpression)) {
return;
}
plugins/InspectionGadgets/src/com/siyeh/ig/verbose/ForCanBeForeachInspection.java
+2 -51
View File
@@ -620,17 +620,6 @@ public class ForCanBeForeachInspection extends StatementInspection {
this.arrayName = arrayName;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAssignmentExpression(PsiAssignmentExpression exp) {
super.visitAssignmentExpression(exp);
final PsiExpression lhs = exp.getLExpression();
@@ -655,18 +644,6 @@ public class ForCanBeForeachInspection extends StatementInspection {
this.iteratorName = iteratorName;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression callExpression) {
super.visitMethodCallExpression(callExpression);
final PsiReferenceExpression methodExpression =
@@ -704,16 +681,6 @@ public class ForCanBeForeachInspection extends StatementInspection {
this.iteratorName = iteratorName;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitAssignmentExpression(PsiAssignmentExpression exp) {
super.visitAssignmentExpression(exp);
@@ -740,16 +707,6 @@ public class ForCanBeForeachInspection extends StatementInspection {
this.iteratorName = iteratorName;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitMethodCallExpression(PsiMethodCallExpression expression) {
super.visitMethodCallExpression(expression);
@@ -784,14 +741,8 @@ public class ForCanBeForeachInspection extends StatementInspection {
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
super.visitReferenceExpression(ref);
final PsiElement element = ref.resolve();
if (!indexVariable.equals(element)) {
return;
plugins/InspectionGadgets/src/com/siyeh/ig/verbose/UnusedLabelInspection.java
-11
View File
@@ -78,17 +78,6 @@ public class UnusedLabelInspection extends StatementInspection {
return m_found;
}
public void visitReferenceExpression(PsiReferenceExpression ref) {
final PsiExpression qualifier = ref.getQualifierExpression();
if (qualifier != null) {
qualifier.accept(this);
}
final PsiReferenceParameterList typeParameters = ref.getParameterList();
if (typeParameters != null) {
typeParameters.accept(this);
}
}
public void visitContinueStatement(PsiContinueStatement continueStatement) {
super.visitContinueStatement(continueStatement);
plugins/InspectionGadgets/src/com/siyeh/ig/verbose/VariableUsedInInnerClassVisitor.java
+1 -5
View File
@@ -24,11 +24,7 @@ public class VariableUsedInInnerClassVisitor extends PsiRecursiveElementVisitor
public void visitReferenceExpression(PsiReferenceExpression reference)
{
final PsiExpression qualifier = reference.getQualifierExpression();
if(qualifier!=null)
{
qualifier.accept(this);
}
super.visitReferenceExpression(reference);
if(m_inInnerClass)
{
final PsiElement element = reference.resolve();