MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[kotlin] Simplify check for receiver being super in UsePropertyAccessSyntaxInspection, and remove useless test

Browse Source 
Test dontReplaceWhenReceiverIsSuper already covers this case

^KTIJ-31647 Fixed


(cherry picked from commit e732a8115a6bc376c9f4e3c82e78b1ea700fd0a8)

IJ-CR-148581

GitOrigin-RevId: 10fc651b4d2a1e38b0df05fb2c2e4e69f10ccd17
This commit is contained in:
Victoria.Petrakovich
2024-11-18 12:38:31 +00:00
committed by intellij-monorepo-bot
parent 4dc92cf3fa
commit b71d2d88d2
4 changed files with 1 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/kotlin/code-insight/inspections-k2/src/org/jetbrains/kotlin/idea/k2/codeinsight/inspections/UsePropertyAccessSyntaxInspection.kt
+1 -3
View File
@@ -165,10 +165,8 @@ class UsePropertyAccessSyntaxInspection : LocalInspectionTool(), CleanupLocalIns
return
}
if (expressionParent is KtDotQualifiedExpression) {
if (expressionParent.receiverExpression is KtSuperExpression) {
if (callExpression.getQualifiedExpressionForSelector()?.receiverExpression is KtSuperExpression) {
return // Shouldn't suggest property accessors on "super"
}
}
if (propertyAccessorKind is PropertyAccessorKind.Setter) {
plugins/kotlin/code-insight/inspections-k2/tests/test/org/jetbrains/kotlin/idea/k2/inspections/tests/K2LocalInspectionTestGenerated.java
-5
View File
@@ -6350,11 +6350,6 @@ public abstract class K2LocalInspectionTestGenerated extends AbstractK2LocalInsp
runTest("../../../idea/tests/testData/inspectionsLocal/usePropertyAccessSyntax/dotQualifiedExpressions/dontReplaceFirstSetterInChain.kt");
}
@TestMetadata("dontReplaceGetterAfterSuperCall.kt")
public void testDontReplaceGetterAfterSuperCall() throws Exception {
runTest("../../../idea/tests/testData/inspectionsLocal/usePropertyAccessSyntax/dotQualifiedExpressions/dontReplaceGetterAfterSuperCall.kt");
}
@TestMetadata("dontReplaceGetterFromKotlinFile.kt")
public void testDontReplaceGetterFromKotlinFile() throws Exception {
runTest("../../../idea/tests/testData/inspectionsLocal/usePropertyAccessSyntax/dotQualifiedExpressions/dontReplaceGetterFromKotlinFile.kt");
plugins/kotlin/idea/tests/test/org/jetbrains/kotlin/idea/inspections/LocalInspectionTestGenerated.java
-5
View File
@@ -19272,11 +19272,6 @@ public abstract class LocalInspectionTestGenerated extends AbstractLocalInspecti
runTest("testData/inspectionsLocal/usePropertyAccessSyntax/dotQualifiedExpressions/dontReplaceFirstSetterInChain.kt");
}
@TestMetadata("dontReplaceGetterAfterSuperCall.kt")
public void testDontReplaceGetterAfterSuperCall() throws Exception {
runTest("testData/inspectionsLocal/usePropertyAccessSyntax/dotQualifiedExpressions/dontReplaceGetterAfterSuperCall.kt");
}
@TestMetadata("dontReplaceGetterFromKotlinFile.kt")
public void testDontReplaceGetterFromKotlinFile() throws Exception {
runTest("testData/inspectionsLocal/usePropertyAccessSyntax/dotQualifiedExpressions/dontReplaceGetterFromKotlinFile.kt");
plugins/kotlin/idea/tests/testData/inspectionsLocal/usePropertyAccessSyntax/dotQualifiedExpressions/dontReplaceGetterAfterSuperCall.kt
-9
View File
@@ -1,9 +0,0 @@
// WITH_STDLIB
// PROBLEM: none
import java.io.File
class MyFile : File("file") {
override fun getCanonicalFile(): File {
return super.<caret>getCanonicalFile()
}
}