MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

GuessManagerImpl: do not run DFA if assignment right-hands have the same type as left-hands

Browse Source 
Fixes IDEA-185290 Too long time takes filling of Ctrl+Space list. (fast code insertion)
This commit is contained in:
Tagir Valeev
2018-01-26 16:14:31 +07:00
parent 148a7b586c
commit b6a99ddaeb
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInsight/guess/impl/GuessManagerImpl.java
+6 -2
View File
@@ -174,13 +174,16 @@ public class GuessManagerImpl extends GuessManager {
}
}
if (place == null) return false;
PsiType type = place.getType();
if (type == null) return false;
final int start = place.getTextRange().getStartOffset();
class Visitor extends JavaRecursiveElementWalkingVisitor {
public boolean hasInteresting;
@Override
public void visitAssignmentExpression(PsiAssignmentExpression expression) {
if (ExpressionTypeMemoryState.EXPRESSION_HASHING_STRATEGY.equals(expression.getLExpression(), place)) {
if (ExpressionTypeMemoryState.EXPRESSION_HASHING_STRATEGY.equals(expression.getLExpression(), place) &&
expression.getRExpression() != null && !type.equals(expression.getRExpression().getType())) {
hasInteresting = true;
stopWalking();
}
@@ -189,7 +192,8 @@ public class GuessManagerImpl extends GuessManager {
@Override
public void visitLocalVariable(PsiLocalVariable variable) {
if (variable.getInitializer() != null && ExpressionUtils.isReferenceTo(place, variable)) {
if (variable.getInitializer() != null && ExpressionUtils.isReferenceTo(place, variable) &&
!type.equals(variable.getInitializer().getType())) {
hasInteresting = true;
stopWalking();
}