MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

RUBY-23014 Replaced immediate file discovery with lazy one. File may be just created and vfs is not yet updated

Browse Source 
IDEA-CR-40106
This commit is contained in:
Alexandr Evstigneev
2018-11-20 13:43:19 +03:00
parent d14c1cdd3d
commit b6927d4d0c
2 changed files with 13 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/lang-api/src/com/intellij/execution/filters/LazyFileHyperlinkInfo.kt
+1 -1
View File
@@ -19,7 +19,7 @@ import com.intellij.openapi.project.Project
import com.intellij.openapi.vfs.LocalFileSystem
import com.intellij.openapi.vfs.VirtualFile
class LazyFileHyperlinkInfo(project: Project, filePath: String, documentLine: Int, documentColumn: Int)
open class LazyFileHyperlinkInfo(project: Project, filePath: String, documentLine: Int, documentColumn: Int)
: FileHyperlinkInfoBase(project, documentLine, documentColumn) {
override val virtualFile: VirtualFile? by lazy {
platform/lang-api/src/com/intellij/execution/filters/UrlFilter.java
+12 -17
View File
@@ -16,19 +16,16 @@
package com.intellij.execution.filters;
import com.intellij.ide.IdeBundle;
import com.intellij.openapi.fileEditor.OpenFileDescriptor;
import com.intellij.openapi.project.DumbAware;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.ui.Messages;
import com.intellij.openapi.util.text.StringUtil;
import com.intellij.openapi.vfs.VfsUtil;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.search.GlobalSearchScope;
import com.intellij.util.io.URLUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.ArrayList;
import java.util.List;
import java.util.regex.Matcher;
@@ -38,6 +35,7 @@ import java.util.regex.Pattern;
* @author yole
*/
public class UrlFilter implements Filter, DumbAware {
private static final String FILE_URL_PROTOCOL = "file://";
private final Project myProject;
public UrlFilter() {
@@ -82,20 +80,17 @@ public class UrlFilter implements Filter, DumbAware {
@Nullable
private HyperlinkInfo buildFileHyperlinkInfo(@NotNull String url) {
if (myProject != null && url.startsWith("file://")) {
try {
VirtualFile file = VfsUtil.findFileByURL(new URL(url));
if (file != null && file.isValid()) {
return new OpenFileHyperlinkInfo(myProject, file, -1);
}
}
catch (MalformedURLException ignored) {
}
return new HyperlinkInfo() {
if (myProject != null && url.startsWith(FILE_URL_PROTOCOL)) {
return new LazyFileHyperlinkInfo(myProject, StringUtil.trimStart(url, FILE_URL_PROTOCOL), 0, 0) {
@Nullable
@Override
public void navigate(Project project) {
Messages.showErrorDialog(project, "Cannot find file " + StringUtil.trimMiddle(url, 150),
IdeBundle.message("title.cannot.open.file"));
public OpenFileDescriptor getDescriptor() {
OpenFileDescriptor descriptor = super.getDescriptor();
if (descriptor == null) {
Messages.showErrorDialog(myProject, "Cannot find file " + StringUtil.trimMiddle(url, 150),
IdeBundle.message("title.cannot.open.file"));
}
return descriptor;
}
};
}