CPP-434 Split [python-community-plugin] into [python-community-core-plugin] and [python-community-java-plugin] #2

python/ide/python-ide-community.iml

@@ -9,10 +9,10 @@
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="module" module-name="platform-impl" />
     <orderEntry type="module" module-name="python-community" />
+    <orderEntry type="module" module-name="python-configure" />
     <orderEntry type="module" module-name="lang-api" />
     <orderEntry type="module" module-name="lang-impl" />
     <orderEntry type="library" name="Guava" level="project" />
     <orderEntry type="module" module-name="xml-psi-impl" />
-    <orderEntry type="module" module-name="python-confugure" />
   </component>
 </module>

python/ide/src/META-INF/pycharm-core.xml

@@ -14,6 +14,7 @@
   <xi:include href="/META-INF/RemoteServers.xml" xpointer="xpointer(/idea-plugin/*)">
     <xi:fallback/>
   </xi:include>
+  <xi:include href="/META-INF/python-configure.xml" xpointer="xpointer(/idea-plugin/*)"/>
 
   <application-components>
     <component>
@@ -40,22 +41,10 @@
 
     <projectAttachProcessor implementation="com.intellij.platform.ModuleAttachProcessor"/>
 
-    <projectConfigurable groupId="project"
-                         id="com.jetbrains.python.configuration.PythonContentEntriesConfigurable"
-                         displayName="Project Structure"
-                         provider="com.jetbrains.python.configuration.PythonContentEntriesConfigurableProvider"/>
     <projectConfigurable groupId="build"
                          id="com.jetbrains.python.buildout.BuildoutModulesConfigurable"
                          displayName="Buildout Support"
                          instance="com.jetbrains.python.buildout.BuildoutModulesConfigurable"/>
-    <projectConfigurable groupId="project"
-                         id="com.jetbrains.python.configuration.PyActiveSdkModuleConfigurable"
-                         displayName="Project Interpreter"
-                         instance="com.jetbrains.python.configuration.PyActiveSdkModuleConfigurable"/>
-    <projectConfigurable groupId="project"
-                         id="com.jetbrains.python.configuration.PyDependenciesConfigurable"
-                         displayName="Project Dependencies"
-                         provider="com.jetbrains.python.configuration.PyDependenciesConfigurableProvider"/>
 
     <directoryProjectConfigurator implementation="com.jetbrains.python.PythonSdkConfigurator" id="sdk"
                                   order="after PlatformProjectConfigurator"/>
@@ -83,9 +72,6 @@
     <applicationService serviceInterface="com.intellij.usages.impl.ImportFilteringUsageViewSetting"
                         serviceImplementation="com.intellij.usages.impl.ImportFilteringUsageViewSetting"/>
 
-    <projectService serviceInterface="com.jetbrains.python.configuration.PyConfigurableInterpreterList"
-                    serviceImplementation="com.jetbrains.python.configuration.PyConfigurableInterpreterList"/>
-
     <bundledColorScheme path="/colorSchemes/monokai"/>
     <bundledColorScheme path="/colorSchemes/twilight"/>
     <bundledColorScheme path="/colorSchemes/WarmNeon"/>

python/python-configure/python-configure.iml

@@ -9,6 +9,7 @@
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="module" module-name="platform-api" />
+    <orderEntry type="module" module-name="lang-api" />
     <orderEntry type="module" module-name="lang-impl" />
     <orderEntry type="module" module-name="python-community" />
     <orderEntry type="library" name="Guava" level="project" />

python/python-configure/resources/META-INF/python-configure-core.xml

@@ -0,0 +1,6 @@
+<idea-plugin version="2">
+  <extensions defaultExtensionNs="com.intellij">
+    <projectService serviceInterface="com.jetbrains.python.configuration.PyConfigurableInterpreterList"
+                    serviceImplementation="com.jetbrains.python.configuration.PyConfigurableInterpreterList"/>
+  </extensions>
+</idea-plugin>

python/python-configure/resources/META-INF/python-configure.xml

@@ -1,4 +1,5 @@
 <idea-plugin version="2">
+  <xi:include href="/META-INF/python-configure-core.xml" xpointer="xpointer(/idea-plugin/*)"/>
   <extensions defaultExtensionNs="com.intellij">
     <projectConfigurable groupId="project"
                          id="com.jetbrains.python.configuration.PythonContentEntriesConfigurable"
@@ -12,7 +13,5 @@
                          id="com.jetbrains.python.configuration.PyDependenciesConfigurable"
                          displayName="Project Dependencies"
                          provider="com.jetbrains.python.configuration.PyDependenciesConfigurableProvider"/>
-    <projectService serviceInterface="com.jetbrains.python.configuration.PyConfigurableInterpreterList"
-                    serviceImplementation="com.jetbrains.python.configuration.PyConfigurableInterpreterList"/>
   </extensions>
 </idea-plugin>

python/python-configure/src/com/jetbrains/python/configuration/PyConfigureInterpretersLinkPanel.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2014 JetBrains s.r.o.
+ * Copyright 2000-2015 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@ import com.intellij.ide.DataManager;
 import com.intellij.openapi.options.ex.Settings;
 import com.intellij.ui.ClickListener;
 import com.intellij.ui.components.JBLabel;
+import com.jetbrains.python.configuration.PyActiveSdkModuleConfigurable;
 import org.jetbrains.annotations.NotNull;
 
 import javax.swing.*;

python/python-configure/src/com/jetbrains/python/configuration/PyDependenciesConfigurableProvider.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2014 JetBrains s.r.o.
+ * Copyright 2000-2015 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@ import com.intellij.openapi.module.ModuleManager;
 import com.intellij.openapi.options.Configurable;
 import com.intellij.openapi.options.ConfigurableProvider;
 import com.intellij.openapi.project.Project;
+import com.jetbrains.python.configuration.PyDependenciesConfigurable;
 
 /**
  * @author Sergey.Malenkov

python/python-configure/src/com/jetbrains/python/configuration/PyDiffPreviewProvider.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2000-2014 JetBrains s.r.o.
+ * Copyright 2000-2015 JetBrains s.r.o.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

python/python-configure/src/com/jetbrains/python/configuration/PythonContentEntriesConfigurableProvider.java

@@ -20,6 +20,7 @@ import com.intellij.openapi.options.Configurable;
 import com.intellij.openapi.options.ConfigurableProvider;
 import com.intellij.openapi.project.Project;
 import com.intellij.util.ArrayUtil;
+import org.jetbrains.annotations.Contract;
 
 /**
  * @author Sergey.Malenkov
@@ -36,6 +37,7 @@ public final class PythonContentEntriesConfigurableProvider extends Configurable
     return ArrayUtil.getFirstElement(ModuleManager.getInstance(myProject).getModules()) != null;
   }
 
+  @Contract(" -> !null")
   @Override
   public Configurable createConfigurable() {
     return new PythonContentEntriesConfigurable(myProject);

python/python-configure/src/com/jetbrains/python/configuration/VirtualEnvProjectFilter.java

@@ -22,6 +22,7 @@ import com.intellij.openapi.projectRoots.Sdk;
 import com.intellij.openapi.util.io.FileUtil;
 import com.jetbrains.python.sdk.PythonSdkAdditionalData;
 import com.jetbrains.python.sdk.PythonSdkType;
+import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.Nullable;
 
 import java.util.List;
@@ -50,6 +51,7 @@ public class VirtualEnvProjectFilter implements Predicate<Sdk> {
     return false;
   }
 
+  @Contract("null, _ -> false")
   public static boolean removeNotMatching(Project project, List<Sdk> sdks) {
     if (project != null) {
       final String basePath = project.getBasePath();