IDEA-125825 Surround with quotes annotation parameter value intention

java/java-impl/src/com/intellij/codeInsight/intention/impl/SurroundWithQuotesStringAnnotationParameterValueIntention.java

@@ -0,0 +1,105 @@
+/*
+* Copyright 2000-2014 JetBrains s.r.o.
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+package com.intellij.codeInsight.intention.impl;
+
+import com.intellij.codeInsight.intention.PsiElementBaseIntentionAction;
+import com.intellij.openapi.editor.Editor;
+import com.intellij.openapi.project.Project;
+import com.intellij.psi.*;
+import com.intellij.psi.tree.IElementType;
+import com.intellij.psi.util.PsiTreeUtil;
+import com.intellij.util.IncorrectOperationException;
+import com.intellij.util.containers.ContainerUtil;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.Set;
+
+/**
+* @author Dmitry Batkovich
+*/
+public class SurroundWithQuotesStringAnnotationParameterValueIntention extends PsiElementBaseIntentionAction {
+  private static final Set<IElementType> SUITABLE_TYPES = ContainerUtil.newHashSet(JavaTokenType.LONG_LITERAL,
+                                                                                   JavaTokenType.FLOAT_LITERAL,
+                                                                                   JavaTokenType.INTEGER_LITERAL,
+                                                                                   JavaTokenType.DOUBLE_LITERAL,
+                                                                                   JavaTokenType.CHARACTER_LITERAL,
+                                                                                   JavaTokenType.TRUE_KEYWORD,
+                                                                                   JavaTokenType.FALSE_KEYWORD);
+
+  @Override
+  public void invoke(@NotNull Project project, Editor editor, @NotNull PsiElement element) throws IncorrectOperationException {
+    String newText = element.getText();
+    if (((PsiJavaToken)element).getTokenType().equals(JavaTokenType.CHARACTER_LITERAL)) {
+      newText = newText.substring(1, newText.length() - 1);
+    }
+    newText = "\"" + newText + "\"";
+    PsiElement newToken = JavaPsiFacade.getInstance(project).getElementFactory().createExpressionFromText(newText, null).getFirstChild();
+    final PsiElement newElement = element.replace(newToken);
+    editor.getCaretModel().moveToOffset(newElement.getTextOffset() + newElement.getTextLength());
+  }
+
+  @Override
+  public boolean isAvailable(@NotNull Project project, Editor editor, @NotNull PsiElement element) {
+    if (!(element instanceof PsiJavaToken && SUITABLE_TYPES.contains(((PsiJavaToken)element).getTokenType()))) {
+      return false;
+    }
+    final PsiElement literalExpression = element.getParent();
+    if (literalExpression == null) {
+      return false;
+    }
+    final PsiElement nameValuePair = literalExpression.getParent();
+    if (!(nameValuePair instanceof PsiNameValuePair)) {
+      return false;
+    }
+    final PsiAnnotation annotation = PsiTreeUtil.getParentOfType(nameValuePair, PsiAnnotation.class);
+    if (annotation == null) {
+      return false;
+    }
+    final PsiJavaCodeReferenceElement nameRef = annotation.getNameReferenceElement();
+    if (nameRef == null) {
+      return false;
+    }
+    final PsiElement resolved = nameRef.resolve();
+    if (!(resolved instanceof PsiClass)) {
+      return false;
+    }
+    final String parameterName = ((PsiNameValuePair)nameValuePair).getName();
+    final PsiMethod[] methods =
+      ((PsiClass)resolved).findMethodsByName(parameterName == null ? PsiAnnotation.DEFAULT_REFERENCED_METHOD_NAME : parameterName, false);
+    if (methods.length != 1) {
+      return false;
+    }
+    final PsiType methodReturnType = methods[0].getReturnType();
+    if (!(methodReturnType instanceof PsiClassType)) {
+      return false;
+    }
+    final PsiClass returnTypeClass = ((PsiClassType)methodReturnType).resolve();
+    return returnTypeClass != null && CommonClassNames.JAVA_LANG_STRING.equals(returnTypeClass.getQualifiedName());
+  }
+
+
+  @NotNull
+  @Override
+  public String getFamilyName() {
+    return "Surround annotation parameter value with quotes";
+  }
+
+  @NotNull
+  @Override
+  public String getText() {
+    return getFamilyName();
+  }
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/afterBoolean.java

@@ -0,0 +1,13 @@
+// "Surround annotation parameter value with quotes" "true"
+class X {
+
+  @interface MyAnnotation {
+    String value();
+  }
+
+  @MyAnnotation("true")
+  void m() {
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/afterChar.java

@@ -0,0 +1,13 @@
+// "Surround annotation parameter value with quotes" "true"
+class X {
+
+  @interface MyAnnotation {
+    String value();
+  }
+
+  @MyAnnotation(value= "x")
+  void m() {
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/afterLong.java

@@ -0,0 +1,15 @@
+// "Surround annotation parameter value with quotes" "true"
+class X {
+
+  @interface MyAnnotation {
+    int value0();
+    String value();
+    long value1();
+  }
+
+  @MyAnnotation(value0 = 1, value= "1000L", value1 = 10L)
+  void m() {
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/beforeBoolean.java

@@ -0,0 +1,13 @@
+// "Surround annotation parameter value with quotes" "true"
+class X {
+
+  @interface MyAnnotation {
+    String value();
+  }
+
+  @MyAnnotation(tr<caret>ue)
+  void m() {
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/beforeChar.java

@@ -0,0 +1,13 @@
+// "Surround annotation parameter value with quotes" "true"
+class X {
+
+  @interface MyAnnotation {
+    String value();
+  }
+
+  @MyAnnotation(value='<caret>x')
+  void m() {
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/beforeLong.java

@@ -0,0 +1,15 @@
+// "Surround annotation parameter value with quotes" "true"
+class X {
+
+  @interface MyAnnotation {
+    int value0();
+    String value();
+    long value1();
+  }
+
+  @MyAnnotation(value0 = 1, value=1<caret>000L, value1 = 10L)
+  void m() {
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/beforeNotAvailable.java

@@ -0,0 +1,10 @@
+// "Surround annotation parameter value with quotes" "false"
+class X {
+
+  void m() {
+
+    String s = 123<caret>45;
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/beforeNotAvailable2.java

@@ -0,0 +1,13 @@
+// "Surround annotation parameter value with quotes" "false"
+class X {
+
+  @interface MyAnnotation {
+    int value();
+  }
+
+  @MyAnnotation(tr<caret>ue)
+  void m() {
+
+  }
+
+}

java/java-tests/testData/codeInsight/surroundWithQuotesStringAnnotationParameterValue/beforeNotAvailable3.java

@@ -0,0 +1,13 @@
+// "Surround annotation parameter value with quotes" "false"
+class X {
+
+  @interface MyAnnotation {
+    String c();
+  }
+
+  @MyAnnotation(tr<caret>ue)
+  void m() {
+
+  }
+
+}

java/java-tests/testSrc/com/intellij/codeInsight/intention/SurroundWithQuotesStringAnnotationParameterValueTest.java

@@ -0,0 +1,31 @@
+/*
+ * Copyright 2000-2014 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.intellij.codeInsight.intention;
+
+import com.intellij.codeInsight.daemon.LightIntentionActionTestCase;
+
+/**
+ * @author Dmitry Batkovich
+ */
+public class SurroundWithQuotesStringAnnotationParameterValueTest extends LightIntentionActionTestCase {
+
+  public void test() throws Exception { doAllTests(); }
+
+  @Override
+  protected String getBasePath() {
+    return "/codeInsight/surroundWithQuotesStringAnnotationParameterValue";
+  }
+}

resources-en/src/intentionDescriptions/SurroundWithQuotesStringAnnotationParameterValueIntention/after.java.template

@@ -0,0 +1,10 @@
+class X {
+
+  @interface Foo {
+    String value();
+  }
+
+  @Foo("123")
+  void m() {
+  }
+}

resources-en/src/intentionDescriptions/SurroundWithQuotesStringAnnotationParameterValueIntention/before.java.template

@@ -0,0 +1,10 @@
+class X {
+
+  @interface Foo {
+    String value();
+  }
+
+  @Foo(<spot>123</spot>)
+  void m() {
+  }
+}

resources-en/src/intentionDescriptions/SurroundWithQuotesStringAnnotationParameterValueIntention/description.html

@@ -0,0 +1,5 @@
+<html>
+<body>
+Intention surrounds annotation parameter value with quotes
+</body>
+</html>

resources/src/META-INF/IdeaPlugin.xml

@@ -884,6 +884,10 @@
       <category>Other</category>
     </intentionAction>
 
+    <intentionAction>
+      <className>com.intellij.codeInsight.intention.impl.SurroundWithQuotesStringAnnotationParameterValueIntention</className>
+      <category>Other</category>
+    </intentionAction>
 
 
     <intentionAction>