IDEA-63641 Eliminate variable itself from autocomplete list

This commit is contained in:
peter
2011-02-23 15:13:39 +01:00
parent 6034b29efd
commit b09a5bed9e
3 changed files with 15 additions and 1 deletions
@@ -39,7 +39,12 @@ public class ExcludeSillyAssignment implements ElementFilter {
final PsiExpression left = ((PsiAssignmentExpression)each).getLExpression();
if (left instanceof PsiReferenceExpression) {
final PsiReferenceExpression referenceExpression = (PsiReferenceExpression)left;
if (referenceExpression.isQualified()) return true;
final PsiElement qualifier = referenceExpression.getQualifier();
if (qualifier != null) {
if (!(qualifier instanceof PsiThisExpression) || ((PsiThisExpression)qualifier).getQualifier() != null) {
return true;
}
}
return !referenceExpression.isReferenceTo((PsiElement)element);
}
@@ -0,0 +1,8 @@
class A {
Object field;
A() {
field = 2;
this.field = fi<caret>
}
}
@@ -961,6 +961,7 @@ public class SmartTypeCompletionTest extends LightFixtureCompletionTestCase {
public void testWildcardedInstanceof3() throws Throwable { doTest(); }
public void testCheckStaticImportsType() throws Throwable { doAntiTest(); }
public void testThisFieldAssignedToItself() throws Throwable { doAntiTest(); }
public void testTypeVariableInstanceOf() throws Throwable {
configureByTestName();