MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-03-22 15:19:59 +07:00
Code Issues Packages Projects Releases Wiki Activity

[fus] Update event names in JdkComboBoxCollector

Browse Source 
IJ-CR-126919

GitOrigin-RevId: 84c41de2aef102a125a3fe7df12d88566292a97b
This commit is contained in:
Louis Vignier
2024-02-28 00:12:42 +01:00
committed by intellij-monorepo-bot
parent 5a0f6f26c6
commit afe5a3ffca
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
java/idea-ui/src/com/intellij/ide/projectWizard/JdkComboBoxCollector.kt
View File

@@ -11,17 +11,17 @@ import com.intellij.openapi.projectRoots.impl.jdkDownloader.JdkItem
import org.jetbrains.jps.model.java.JdkVersionDetector
internal object JdkComboBoxCollector: CounterUsagesCollector() {
private val GROUP: EventLogGroup = EventLogGroup("npw.jdk.combo", 1)
private val GROUP: EventLogGroup = EventLogGroup("npw.jdk.combo", 2)
private const val UNKNOWN_VENDOR = "unknown"
private val KNOWN_VENDORS = JdkVersionDetector.Variant.entries
.mapNotNull { it.displayName }
.toList() + UNKNOWN_VENDOR
private val SETUP_EXISTING: EventId2<String, Int> = GROUP.registerEvent("setup.existing",
private val JDK_REGISTERED: EventId2<String, Int> = GROUP.registerEvent("jdk.registered",
EventFields.String("vendor", KNOWN_VENDORS),
EventFields.Int("version"))
private val SETUP_NO_JDK: EventId = GROUP.registerEvent("no.jdk")
private val DOWNLOAD_JDK: EventId2<String, Int> = GROUP.registerEvent("download.jdk",
private val NO_JDK_SELECTED: EventId = GROUP.registerEvent("no.jdk.selected")
private val JDK_DOWNLOADED: EventId2<String, Int> = GROUP.registerEvent("jdk.downloaded",
EventFields.String("vendor", KNOWN_VENDORS),
EventFields.Int("version"))
@@ -37,11 +37,11 @@ internal object JdkComboBoxCollector: CounterUsagesCollector() {
val version = findSdkVersion(sdkVersionString)
SETUP_EXISTING.log(variant, version)
JDK_REGISTERED.log(variant, version)
}
fun noJdkRegistered() {
SETUP_NO_JDK.log()
fun noJdkSelected() {
NO_JDK_SELECTED.log()
}
private fun findSdkVersion(sdkVersionString: String?): Int = when (sdkVersionString) {
@@ -61,6 +61,6 @@ internal object JdkComboBoxCollector: CounterUsagesCollector() {
else -> UNKNOWN_VENDOR
}
DOWNLOAD_JDK.log(vendor, findSdkVersion(item.presentableMajorVersionString))
JDK_DOWNLOADED.log(vendor, findSdkVersion(item.presentableMajorVersionString))
}
}

2
java/idea-ui/src/com/intellij/ide/projectWizard/ProjectWizardJdkComboBox.kt
View File

@@ -104,7 +104,7 @@ fun Row.projectWizardJdkComboBox(
context.projectJdk = sdkProperty.get()
when (val selected = combo.selectedItem) {
is NoJdk -> JdkComboBoxCollector.noJdkRegistered()
is NoJdk -> JdkComboBoxCollector.noJdkSelected()
is DownloadJdk -> JdkComboBoxCollector.jdkDownloaded((selected.task as JdkDownloadTask).jdkItem)
}
}