MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[dev kit] special for Peter: /s/extension/quick fix/ in StatefulEpInspection

Browse Source
This commit is contained in:
Sergey Ignatov
2016-03-17 02:09:38 +03:00
parent b83cfcb8e8
commit af5ba8b54b
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/devkit/src/inspections/StatefulEpInspection.java
+1 -1
View File
@@ -48,7 +48,7 @@ public class StatefulEpInspection extends DevKitInspectionBase {
String message = c == PsiElement.class
? "Potential memory leak: don't hold PsiElement, use SmartPsiElementPointer instead" +
(isQuickFix ? "; also see LocalQuickFixOnPsiElement" : "")
: "Don't use " + c.getSimpleName() + " as a field in extension";
: "Don't use " + c.getSimpleName() + " as a field in " + ( isQuickFix ? "quick fix" : "extension");
if (InheritanceUtil.isInheritor(field.getType(), c.getCanonicalName())) {
result.add(manager.createProblemDescriptor(field, message, true, ProblemHighlightType.GENERIC_ERROR_OR_WARNING, isOnTheFly));
}
plugins/devkit/testData/inspections/statefulEp/Fix.java
+2 -2
View File
@@ -1,7 +1,7 @@
public class Fix extends com.intellij.codeInspection.LocalQuickFix {
<warning descr="Potential memory leak: don't hold PsiElement, use SmartPsiElementPointer instead; also see LocalQuickFixOnPsiElement">final com.intellij.psi.PsiElement pe;</warning>
<warning descr="Don't use PsiReference as a field in extension">final com.intellij.psi.PsiReference r;</warning>
<warning descr="Don't use Project as a field in extension">com.intellij.openapi.project.Project p;</warning>
<warning descr="Don't use PsiReference as a field in quick fix">final com.intellij.psi.PsiReference r;</warning>
<warning descr="Don't use Project as a field in quick fix">com.intellij.openapi.project.Project p;</warning>
final com.intellij.openapi.project.Project pf;
public Fix() {
super();