MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-06 03:21:12 +07:00
Code Issues Packages Projects Releases Wiki Activity

Don't subscribe to events on app initialization

Browse Source 
Otherwise, subscription causes ~100-200ms degradation in the "app initialization" metric. Besides, subscribing so early is not necessary anyway since kill signal might come only after the project is opened (1+ minute after the test started).

GitOrigin-RevId: 04b3c398fe1c370b4a072f1475c16a90020a49fd
This commit is contained in:
Maxim.Kolmakov
2024-05-10 13:30:46 +02:00
committed by intellij-monorepo-bot
parent 38b8372efd
commit ae9ca3dde6
1 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
plugins/performanceTesting/core/src/com/jetbrains/performancePlugin/ProjectLoaded.kt
View File

@@ -92,6 +92,25 @@ private object ProjectLoadedService {
}
}
private fun subscribeToStopProfile() {
if (ApplicationManagerEx.isInIntegrationTest()) {
try {
EventsBus.subscribe("ProfileStopSubscriber") { event: StopProfilerEvent ->
try {
getCurrentProfilerHandler().stopProfiling(event.data)
}
catch (t: Throwable) {
LOG.info("Error stop profiling", t)
}
}
}
catch (connectException: ConnectException) {
// Some integration tests don't start event bus server. e.g com.jetbrains.rdct.cwm.distributed.connectionTypes.LocalRelayTest
LOG.info("Subscription to stop profiling failed", connectException)
}
}
}
private fun runOnProjectInit(project: Project) {
if (System.getProperty("ide.performance.screenshot") != null) {
(ProjectLoadedService.registerScreenshotTaking(System.getProperty("ide.performance.screenshot"),
@@ -110,6 +129,9 @@ private fun runOnProjectInit(project: Project) {
LOG.info("Start Execution")
PerformanceTestSpan.startSpan()
subscribeToStopProfile()
val profilerSettings = initializeProfilerSettingsForIndexing()
if (profilerSettings != null) {
try {
@@ -191,22 +213,6 @@ class ProjectLoaded : ApplicationInitializedListener {
{ PerformanceTestSpan.getContext() },
{ takeFullScreenshot(it) })
}
if (ApplicationManagerEx.isInIntegrationTest()) {
try {
EventsBus.subscribe(this) { event: StopProfilerEvent ->
try {
getCurrentProfilerHandler().stopProfiling(event.data)
} catch (t: Throwable) {
LOG.info("Error stop profiling", t)
}
}
} catch (connectException: ConnectException) {
// Some integration tests don't start event bus server. e.g com.jetbrains.rdct.cwm.distributed.connectionTypes.LocalRelayTest
LOG.info("Subscription to stop profiling failed", connectException)
}
}
if (ApplicationManagerEx.getApplicationEx().isLightEditMode) {
LightEditService.getInstance().editorManager.addListener(object : LightEditorListener {
override fun afterSelect(editorInfo: LightEditorInfo?) {