MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

junit 5.1: don't suggest private for extension fields (IDEA-188590)

Browse Source
This commit is contained in:
Anna.Kozlova
2018-03-20 17:00:29 +01:00
parent 769b2f2808
commit add6b98082
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/junit/JUnitCommonClassNames.java
+1
View File
@@ -55,4 +55,5 @@ public class JUnitCommonClassNames {
public static final String ORG_JUNIT_JUPITER_API_EXTENSION_EXTEND_WITH = "org.junit.jupiter.api.extension.ExtendWith";
public static final String ORG_JUNIT_JUPITER_API_TEST_INSTANCE = "org.junit.jupiter.api.TestInstance";
public static final String ORG_JUNIT_PLATFORM_ENGINE_TEST_ENGINE = "org.junit.platform.engine.TestEngine";
public static final String ORG_JUNIT_JUPITER_API_EXTENSION_REGISTER_EXTENSION = "org.junit.jupiter.api.extension.RegisterExtension";
}
plugins/junit/src/com/intellij/execution/junit2/inspection/JUnitEntryPoint.java
+6
View File
@@ -15,6 +15,7 @@ import com.intellij.psi.util.PsiClassUtil;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.util.PsiUtil;
import com.intellij.util.CommonProcessors;
import com.siyeh.ig.junit.JUnitCommonClassNames;
import org.jdom.Element;
import org.jetbrains.annotations.NotNull;
@@ -77,6 +78,11 @@ public class JUnitEntryPoint extends EntryPointWithVisibilityLevel {
if (container != null && JUnitUtil.isJUnit5TestClass(container, false)) {
return PsiUtil.ACCESS_LEVEL_PACKAGE_LOCAL;
}
if (member instanceof PsiField &&
AnnotationUtil.isAnnotated(member, JUnitCommonClassNames.ORG_JUNIT_JUPITER_API_EXTENSION_REGISTER_EXTENSION, 0)) {
return PsiUtil.ACCESS_LEVEL_PACKAGE_LOCAL;
}
return -1;
}