MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

DevKit: adjust inspection error message with the new validation rules

Browse Source 
GitOrigin-RevId: 86cc687747a44467e5d55ce25308fcb308d46f1f
This commit is contained in:
Alexander Zolotov
2019-09-16 19:02:03 +00:00
committed by intellij-monorepo-bot
parent d049a6d3ac
commit ada6cb0671
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/devkit/devkit-core/resources/org/jetbrains/idea/devkit/DevKitBundle.properties
-1
View File
@@ -149,7 +149,6 @@ inspections.group.description.file=Description file
inspections.group.code=Code
inspections.plugin.xml.inner.class.must.be.separated.with.dollar=Inner class must be separated with '$'
inspections.plugin.xml.plugin.should.have.jetbrains.vendor=Plugin developed as a part of IntelliJ IDEA project should specify 'JetBrains' as its vendor
inspections.plugin.xml.plugin.should.include.jetbrains.vendor=Plugin developed as a part of IntelliJ IDEA project should include 'JetBrains' as one of its vendors
inspections.plugin.xml.plugin.jetbrains.vendor.no.url=Plugin developed as a part of IntelliJ IDEA project shouldn''t specify ''{0}'' as url
inspections.plugin.xml.plugin.jetbrains.vendor.no.email=Plugin developed as a part of IntelliJ IDEA project shouldn't specify email
inspections.plugin.xml.plugin.jetbrains.no.version=Plugin developed as a part of IntelliJ IDEA project shouldn't specify version
plugins/devkit/devkit-core/src/inspections/PluginXmlDomInspection.java
+2 -2
View File
@@ -407,8 +407,8 @@ public class PluginXmlDomInspection extends BasicDomElementsInspection<IdeaPlugi
DevKitBundle.message("inspections.plugin.xml.plugin.should.have.jetbrains.vendor"),
new AddMissingMainTag("Specify JetBrains as vendor", vendor, PluginManagerMain.JETBRAINS_VENDOR));
}
else if (!PluginManagerMain.isDevelopedByJetBrains(vendor.getValue())) {
holder.createProblem(vendor, DevKitBundle.message("inspections.plugin.xml.plugin.should.include.jetbrains.vendor"));
else if (!PluginManagerMain.JETBRAINS_VENDOR.equals(vendor.getValue())) {
holder.createProblem(vendor, DevKitBundle.message("inspections.plugin.xml.plugin.should.have.jetbrains.vendor"));
}
else {
final String url = vendor.getUrl().getStringValue();
plugins/devkit/devkit-java-tests/testData/codeInsight/pluginWithThirdPartyVendor.xml
+1 -1
View File
@@ -1,4 +1,4 @@
<idea-plugin>
<id>test</id>
<vendor><error descr="Plugin developed as a part of IntelliJ IDEA project should include 'JetBrains' as one of its vendors">me</error></vendor>
<vendor><error descr="Plugin developed as a part of IntelliJ IDEA project should specify 'JetBrains' as its vendor">me</error></vendor>
</idea-plugin>