MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

move "Inner class may be 'static'" inspection to "Memory issues" group

Browse Source
This commit is contained in:
Bas Leijdekkers
2014-09-07 16:10:47 +02:00
parent 1481f3bc56
commit ad47a42d0c
10 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/META-INF/InspectionGadgets.xml
+4 -4
View File
@@ -1543,6 +1543,10 @@
key="anonymous.inner.may.be.named.static.inner.class.display.name" groupBundle="messages.InspectionsBundle"
groupKey="group.names.memory.issues" enabledByDefault="false" level="WARNING"
implementationClass="com.siyeh.ig.memory.AnonymousInnerClassMayBeStaticInspection"/>
<localInspection language="JAVA" shortName="InnerClassMayBeStatic" bundle="com.siyeh.InspectionGadgetsBundle"
key="inner.class.may.be.static.display.name" groupBundle="messages.InspectionsBundle"
groupKey="group.names.memory.issues" enabledByDefault="false" level="WARNING" runForWholeFile="true"
implementationClass="com.siyeh.ig.memory.InnerClassMayBeStaticInspection"/>
<localInspection language="JAVA" shortName="StaticCollection" bundle="com.siyeh.InspectionGadgetsBundle" key="static.collection.display.name"
groupBundle="messages.InspectionsBundle" groupKey="group.names.memory.issues" enabledByDefault="false" level="WARNING"
implementationClass="com.siyeh.ig.memory.StaticCollectionInspection"/>
@@ -1910,10 +1914,6 @@
<localInspection language="JAVA" shortName="FieldMayBeStatic" bundle="com.siyeh.InspectionGadgetsBundle" key="field.may.be.static.display.name"
groupBundle="messages.InspectionsBundle" groupKey="group.names.performance.issues" enabledByDefault="false"
level="WARNING" implementationClass="com.siyeh.ig.performance.FieldMayBeStaticInspection"/>
<localInspection language="JAVA" shortName="InnerClassMayBeStatic" bundle="com.siyeh.InspectionGadgetsBundle"
key="inner.class.may.be.static.display.name" groupBundle="messages.InspectionsBundle"
groupKey="group.names.performance.issues" enabledByDefault="false" level="WARNING" runForWholeFile="true"
implementationClass="com.siyeh.ig.performance.InnerClassMayBeStaticInspection"/>
<localInspection language="JAVA" shortName="InstantiatingObjectToGetClassObject" bundle="com.siyeh.InspectionGadgetsBundle"
key="instantiating.object.to.get.class.object.display.name" groupBundle="messages.InspectionsBundle"
groupKey="group.names.performance.issues" enabledByDefault="true" level="WARNING"
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/memory/AnonymousInnerClassMayBeStaticInspectionBase.java
-1
View File
@@ -20,7 +20,6 @@ import com.intellij.psi.util.PsiTreeUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.performance.InnerClassReferenceVisitor;
import org.jetbrains.annotations.NotNull;
public class AnonymousInnerClassMayBeStaticInspectionBase extends BaseInspection {
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/InnerClassMayBeStaticInspection.java → plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/memory/InnerClassMayBeStaticInspection.java
+2 -1
View File
@@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.performance;
package com.siyeh.ig.memory;
import com.intellij.codeInsight.FileModificationService;
import com.intellij.codeInspection.ProblemDescriptor;
@@ -27,6 +27,7 @@ import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.memory.InnerClassReferenceVisitor;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList;
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/InnerClassReferenceVisitor.java → plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/memory/InnerClassReferenceVisitor.java
+3 -3
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2003-2013 Dave Griffith, Bas Leijdekkers
* Copyright 2003-2014 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.performance;
package com.siyeh.ig.memory;
import com.intellij.psi.*;
import com.intellij.psi.util.InheritanceUtil;
@@ -21,7 +21,7 @@ import com.intellij.psi.util.PsiTreeUtil;
import com.siyeh.ig.psiutils.ClassUtils;
import org.jetbrains.annotations.NotNull;
public class InnerClassReferenceVisitor extends JavaRecursiveElementVisitor {
class InnerClassReferenceVisitor extends JavaRecursiveElementVisitor {
private final PsiClass innerClass;
private boolean referencesStaticallyAccessible = true;
plugins/InspectionGadgets/test/com/siyeh/igfixes/performance/inner_class_static/Simple.after.java → plugins/InspectionGadgets/test/com/siyeh/igfixes/memory/inner_class_static/Simple.after.java
+1 -1
View File
@@ -1,4 +1,4 @@
package performance.inner_class_static;
package memory.inner_class_static;
class Simple {
static class Inner {}
plugins/InspectionGadgets/test/com/siyeh/igfixes/performance/inner_class_static/Simple.java → plugins/InspectionGadgets/test/com/siyeh/igfixes/memory/inner_class_static/Simple.java
+1 -1
View File
@@ -1,4 +1,4 @@
package performance.inner_class_static;
package memory.inner_class_static;
class Simple {
class Inner<caret> {}
plugins/InspectionGadgets/test/com/siyeh/igtest/performance/inner_class_may_be_static/InnerClassMayBeStaticInspection.java → plugins/InspectionGadgets/test/com/siyeh/igtest/memory/inner_class_may_be_static/InnerClassMayBeStaticInspection.java
+1 -1
View File
@@ -1,4 +1,4 @@
package com.siyeh.igtest.performance.inner_class_may_be_static;
package com.siyeh.igtest.memory.inner_class_may_be_static;
import javax.swing.*;
plugins/InspectionGadgets/test/com/siyeh/igtest/performance/inner_class_may_be_static/expected.xml → plugins/InspectionGadgets/test/com/siyeh/igtest/memory/inner_class_may_be_static/expected.xml
View File
plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/performance/InnerClassMayBeStaticFixTest.java → plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/memory/InnerClassMayBeStaticFixTest.java
+3 -3
View File
@@ -13,11 +13,11 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.fixes.performance;
package com.siyeh.ig.fixes.memory;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.IGQuickFixesTestCase;
import com.siyeh.ig.performance.InnerClassMayBeStaticInspection;
import com.siyeh.ig.memory.InnerClassMayBeStaticInspection;
/**
* @author Bas Leijdekkers
@@ -28,7 +28,7 @@ public class InnerClassMayBeStaticFixTest extends IGQuickFixesTestCase {
protected void setUp() throws Exception {
super.setUp();
myFixture.enableInspections(new InnerClassMayBeStaticInspection());
myRelativePath = "performance/inner_class_static";
myRelativePath = "memory/inner_class_static";
myDefaultHint = InspectionGadgetsBundle.message("make.static.quickfix");
}
plugins/InspectionGadgets/testsrc/com/siyeh/ig/performance/InnerClassMayBeStaticInspectionTest.java → plugins/InspectionGadgets/testsrc/com/siyeh/ig/memory/InnerClassMayBeStaticInspectionTest.java
+2 -2
View File
@@ -1,11 +1,11 @@
package com.siyeh.ig.performance;
package com.siyeh.ig.memory;
import com.siyeh.ig.IGInspectionTestCase;
public class InnerClassMayBeStaticInspectionTest extends IGInspectionTestCase {
public void test() throws Exception {
doTest("com/siyeh/igtest/performance/inner_class_may_be_static",
doTest("com/siyeh/igtest/memory/inner_class_may_be_static",
new InnerClassMayBeStaticInspection());
}
}