MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[debugger] new UI for inline breakpoints, IDEA-324621

Browse Source 
Disable incompatible breakpoint/variant problems. :(

GitOrigin-RevId: 4cc2b7aefb22c554c5b1c67e350acfcef0371e59
This commit is contained in:
Vladimir Parfinenko
2023-12-19 15:59:00 +00:00
committed by intellij-monorepo-bot
parent 3683849609
commit acb543eaa7
1 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/xdebugger-impl/src/com/intellij/xdebugger/impl/breakpoints/InlineBreakpointInlayManager.kt
+22 -1
View File
@@ -249,8 +249,11 @@ internal class InlineBreakpointInlayManager(private val project: Project, privat
if (!shouldAlwaysShowAllInlays() &&
breakpoints.size == 1 &&
(variants.isEmpty() ||
variants.size == 1 && areMatching(variants[0], breakpoints[0]))) {
variants.size == 1 && areMatching(variants.first(), breakpoints.first()))) {
// No need to show inline variants when there is only one breakpoint and one matching variant (or no variants at all).
if (variants.isEmpty()) {
reportBreakpointWithoutVariants(document, line, breakpoints.first())
}
return emptyList()
}
@@ -341,6 +344,12 @@ internal class InlineBreakpointInlayManager(private val project: Project, privat
private fun reportSingleVariantMultipleBreakpoints(document: Document, line: Int,
variant: XLineBreakpointType<*>.XLineBreakpointVariant,
breakpoints: List<XLineBreakpointImpl<*>>) {
if (true) {
// There are a lot of false positives, due to data races with breakpoints update, outdated state,
// FIXME[inline-bp]: get rid of reporting or make it more relieable
return
}
logger.error("single variant (${formatTextRangeForErrors(variant.highlightRange)}) " +
"matches ${breakpoints.size} breakpoints " +
"${breakpoints.map { formatTextRangeForErrors(getBreakpointHighlightRange(it)) }} " +
@@ -351,6 +360,12 @@ internal class InlineBreakpointInlayManager(private val project: Project, privat
private fun reportSingleBreakpointMultipleVariants(document: Document, line: Int,
breakpoint: XLineBreakpointImpl<*>,
variants: List<XLineBreakpointType<*>.XLineBreakpointVariant>) {
if (true) {
// There are a lot of false positives, due to data races with breakpoints update, outdated state,
// FIXME[inline-bp]: get rid of reporting or make it more relieable
return
}
logger.error("single breakpoint (${formatTextRangeForErrors(getBreakpointHighlightRange(breakpoint))}) " +
"matches ${variants.size} variants " +
"${variants.map { formatTextRangeForErrors(it.highlightRange) }} " +
@@ -360,6 +375,12 @@ internal class InlineBreakpointInlayManager(private val project: Project, privat
private fun reportBreakpointWithoutVariants(document: Document, line: Int,
breakpoint: XLineBreakpointImpl<*>) {
if (true) {
// There are a lot of false positives, due to data races with breakpoints update, outdated state,
// FIXME[inline-bp]: get rid of reporting or make it more relieable
return
}
logger.error("breakpoint (${formatTextRangeForErrors(getBreakpointHighlightRange(breakpoint))}) " +
"matches no variants " +
"at line ${line + 1}",