MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 13:20:53 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-inspections] IDEA-298388 "Java | Code style issues | Non-terminal use of '\s' escape sequence" false positive

Browse Source 
GitOrigin-RevId: 3e7989a3bf971e7b6be613abee893cbe334dde31
This commit is contained in:
Tagir Valeev
2022-07-25 16:11:56 +02:00
committed by intellij-monorepo-bot
parent 84a630bfbe
commit aaa9392f8b
2 changed files with 33 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/java-tests/testData/codeInspection/escapedSpace/beforeSlashSlash.java Normal file
View File

@@ -0,0 +1,8 @@
// "Replace with a space" "false"
class X {
void test(String str) {
if (str.matches("\\<caret>s+")) {
}
}
}

33
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/EscapedSpaceInspection.java
View File

@@ -22,16 +22,33 @@ public class EscapedSpaceInspection extends AbstractBaseJavaLocalInspectionTool
if (!TypeUtils.isJavaLangString(type)) return;
boolean block = literal.isTextBlock();
String text = literal.getText();
int pos = 0;
int pos = 1;
while (true) {
pos = text.indexOf("\\s", pos + 1);
if (pos == -1) return;
if (pos > 2 && text.startsWith("\\s", pos - 2)) continue;
if (text.startsWith("\\s", pos + 2)) continue;
if (block && (pos + 2 == text.length() || text.charAt(pos + 2) == '\n')) continue;
holder.registerProblem(literal, TextRange.create(pos, pos+2),
pos = text.indexOf('\\', pos);
if (pos == -1 || pos == text.length() - 1) return;
char next = text.charAt(pos + 1);
if (next == 'u') {
// unicode escape
pos += 6;
continue;
}
pos += 2;
if (next >= '0' && next <= '9') {
// octal escape
if (pos < text.length() && text.charAt(pos) >= '0' && text.charAt(pos) <= '9') pos++;
if (pos < text.length() && text.charAt(pos) >= '0' && text.charAt(pos) <= '9') pos++;
continue;
}
if (next != 's') {
// other escapes
continue;
}
if (pos > 4 && text.startsWith("\\s", pos - 4)) continue;
if (text.startsWith("\\s", pos)) continue;
if (block && (pos == text.length() || text.charAt(pos) == '\n')) continue;
holder.registerProblem(literal, TextRange.create(pos - 2, pos),
InspectionGadgetsBundle.message("inspection.use.of.slash.s.message"),
new ReplaceWithSpaceFix(pos));
new ReplaceWithSpaceFix(pos - 2));
}
}
};