MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Highlight assignment expressions within a comprehension in a class body as errors (PEP 572) (PY-33886)

Browse Source 
GitOrigin-RevId: 1b63427a4c5e4927be07fdc4bcec91bd952e26c7
This commit is contained in:
Semyon Proshev
2019-07-02 06:52:16 +03:00
committed by intellij-monorepo-bot
parent 17dd3b8981
commit aa1da541de
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/validation/AssignTargetAnnotator.java
+11
View File
@@ -16,7 +16,10 @@
package com.jetbrains.python.validation;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.util.PsiTreeUtil;
import com.jetbrains.python.PyNames;
import com.jetbrains.python.codeInsight.controlflow.ScopeOwner;
import com.jetbrains.python.codeInsight.dataflow.scope.ScopeUtil;
import com.jetbrains.python.psi.*;
import com.jetbrains.python.sdk.PythonSdkType;
import org.jetbrains.annotations.NotNull;
@@ -104,6 +107,14 @@ public class AssignTargetAnnotator extends PyAnnotator {
errorOnUnparenthesizedAssignmentExpression(node.getValue(), "as annotations for arguments, return values and assignments");
}
@Override
public void visitPyAssignmentExpression(PyAssignmentExpression node) {
final PyComprehensionElement comprehensionElement = PsiTreeUtil.getParentOfType(node, PyComprehensionElement.class, true, ScopeOwner.class);
if (ScopeUtil.getScopeOwner(comprehensionElement) instanceof PyClass) {
getHolder().createErrorAnnotation(node, "Assignment expressions within a comprehension cannot be used in a class body");
}
}
private void errorOnUnparenthesizedAssignmentExpression(@Nullable PyExpression expression, @NotNull String suffix) {
if (expression instanceof PyAssignmentExpression) {
getHolder().createErrorAnnotation(expression, "Unparenthesized assignment expressions are prohibited " + suffix);
python/testData/highlighting/invalidAssignmentExpressions.py
+4 -1
View File
@@ -20,4 +20,7 @@ def foo(answer: (p := 42) = 5): # Valid, but probably never useful
(lambda: <error descr="Unparenthesized assignment expressions are prohibited at the top level of a lambda function">x := 1</error>) # INVALID
lambda: (x := 1) # Valid, but unlikely to be useful
(x := lambda: 1) # Valid
lambda line: (m := re.match(pattern, line)) and m.group(1) # Valid
lambda line: (m := re.match(pattern, line)) and m.group(1) # Valid
class A:
[<error descr="Assignment expressions within a comprehension cannot be used in a class body">y := i</error> for i in range(2)]