MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-16 14:23:28 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-263518 "Add as Ant Build File" action should not be shown for Maven files

Browse Source 
GitOrigin-RevId: 6b88937b9631da629fab1652a51ea6ad0f82b84a
This commit is contained in:
Vladislav Rassokhin
2025-03-15 18:06:26 +01:00
committed by intellij-monorepo-bot
parent eb6aed5f0f
commit a105989d41
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/ant/src/com/intellij/lang/ant/config/actions/AddAntBuildFile.java
View File

@@ -88,7 +88,7 @@ public final class AddAntBuildFile extends AnAction {
if (project != null) {
final VirtualFile[] files = e.getData(CommonDataKeys.VIRTUAL_FILE_ARRAY);
if (files != null) {
for (VirtualFile file : files) {
files: for (VirtualFile file : files) {
final PsiFile psiFile = PsiManager.getInstance(project).findFile(file);
if (!(psiFile instanceof XmlFile xmlFile)) {
continue;
@@ -110,6 +110,12 @@ public final class AddAntBuildFile extends AnAction {
if ("http://maven.apache.org/POM/4.0.0".equals(rootTag.getNamespace())) {
continue;
}
for (XmlTag tag : rootTag.getSubTags()) {
String name = tag.getName();
if (name.equals("modelVersion")) continue files;
if (name.equals("groupId")) continue files;
if (name.equals("artifactId")) continue files;
}
// found at least one candidate file
enable(presentation);
return;

24
plugins/ant/tests/src/com/intellij/lang/ant/config/actions/AddAntBuildFileTest.java
View File

@@ -1,7 +1,8 @@
// Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.intellij.lang.ant.config.actions;
import com.intellij.openapi.actionSystem.ActionPlaces;
import com.intellij.openapi.actionSystem.ActionUiKind;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.CommonDataKeys;
import com.intellij.openapi.vfs.VirtualFile;
@@ -47,16 +48,33 @@ public class AddAntBuildFileTest extends LightPlatformTestCase {
assertFalse(event.getPresentation().isEnabledAndVisible());
}
@Test
public void testDisabledOnMavenProjectFileWithoutNamespace() {
final VirtualFile file = VfsTestUtil.createFile(getSourceRoot(), "pom.xml", """
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>com.intellij.lang.ant.config.actions</groupId>
<artifactId>test</artifactId>
<version>0.1-SNAPSHOT</version>
</project>
""");
final AnActionEvent event = doUpdate(file);
assertFalse(event.getPresentation().isEnabled());
assertFalse(event.getPresentation().isVisible());
assertFalse(event.getPresentation().isEnabledAndVisible());
}
private @NotNull AnActionEvent doUpdate(VirtualFile file) {
final AddAntBuildFile action = new AddAntBuildFile();
final VirtualFile[] files = {file};
final TestDataProvider provider = new TestDataProvider(getProject());
final AnActionEvent event = AnActionEvent.createFromAnAction(action, null, ActionPlaces.PROJECT_VIEW_POPUP, dataId -> {
final AnActionEvent event = AnActionEvent.createEvent(action, dataId -> {
if (CommonDataKeys.VIRTUAL_FILE_ARRAY.is(dataId)) {
return files;
}
return provider.getData(dataId);
});
}, null, ActionPlaces.PROJECT_VIEW_POPUP, ActionUiKind.NONE, null);
action.update(event);
return event;
}