MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

add a bunch of not nulls to ImplicitUsageProvider

Browse Source 
GitOrigin-RevId: 0ef8ba53d58cb80ff232fe0a70ae6ee89ffd12c7
This commit is contained in:
Sergey Ignatov
2019-07-02 06:52:16 +03:00
committed by intellij-monorepo-bot
parent bd23318cb4
commit a0760dfd74
15 changed files with 49 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/psi/impl/source/resolve/reference/impl/AtomicReferenceImplicitUsageProvider.java
+3 -3
View File
@@ -33,17 +33,17 @@ public class AtomicReferenceImplicitUsageProvider implements ImplicitUsageProvid
"incrementAndGet", "decrementAndGet", "addAndGet", "getAndUpdate", "updateAndGet", "getAndAccumulate", "accumulateAndGet");
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
if (element instanceof PsiField) {
PsiField field = (PsiField)element;
if (field.hasModifierProperty(PsiModifier.VOLATILE)) {
java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/LightUnusedHighlightingFixtureTest.java
+3 -3
View File
@@ -21,17 +21,17 @@ public class LightUnusedHighlightingFixtureTest extends LightJavaCodeInsightFixt
myFixture.enableInspections(new UnusedDeclarationInspection(true));
ImplicitUsageProvider.EP_NAME.getPoint(null).registerExtension(new ImplicitUsageProvider() {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return element instanceof PsiField && "implicitWrite".equals(((PsiNamedElement)element).getName());
}
}, getTestRootDisposable());
java/java-tests/testSrc/com/intellij/java/codeInspection/CanBeFinalTest.java
+4 -3
View File
@@ -9,6 +9,7 @@ import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiField;
import com.intellij.psi.PsiNamedElement;
import com.intellij.testFramework.JavaInspectionTestCase;
import org.jetbrains.annotations.NotNull;
public class CanBeFinalTest extends JavaInspectionTestCase {
@Override
@@ -130,17 +131,17 @@ public class CanBeFinalTest extends JavaInspectionTestCase {
public void testfieldImplicitWrite() {
ImplicitUsageProvider.EP_NAME.getPoint(null).registerExtension(new ImplicitUsageProvider() {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return isImplicitWrite(element);
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return element instanceof PsiField && "implicitWrite".equals(((PsiNamedElement)element).getName());
}
}, getTestRootDisposable());
java/java-tests/testSrc/com/intellij/java/codeInspection/DataFlowInspectionTest.java
+3 -3
View File
@@ -538,17 +538,17 @@ public class DataFlowInspectionTest extends DataFlowInspectionTestCase {
public void testImplicitlyInitializedField() {
ImplicitUsageProvider.EP_NAME.getPoint(null).registerExtension(new ImplicitUsageProvider() {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return false;
}
java/java-tests/testSrc/com/intellij/java/codeInspection/UnusedReturnValueQuickFixTest.java
+3 -3
View File
@@ -43,17 +43,17 @@ public class UnusedReturnValueQuickFixTest extends LightJavaCodeInsightFixtureTe
super.setUp();
PlatformTestUtil.registerExtension(Extensions.getRootArea(), ImplicitUsageProvider.EP_NAME, new ImplicitUsageProvider() {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return element instanceof PsiMethod && ((PsiMethod)element).getName().equals("implicitRead");
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return false;
}
}, getTestRootDisposable());
platform/analysis-api/src/com/intellij/codeInsight/daemon/ImplicitUsageProvider.java
+3 -3
View File
@@ -36,17 +36,17 @@ public interface ImplicitUsageProvider {
/**
* @return true if element should not be reported as unused
*/
boolean isImplicitUsage(PsiElement element);
boolean isImplicitUsage(@NotNull PsiElement element);
/**
* @return true if element should not be reported as "assigned but not used"
*/
boolean isImplicitRead(PsiElement element);
boolean isImplicitRead(@NotNull PsiElement element);
/**
* @return true if element should not be reported as "referenced but never assigned"
*/
boolean isImplicitWrite(PsiElement element);
boolean isImplicitWrite(@NotNull PsiElement element);
/**
* @return true if the given element is implicitly initialized to a non-null value
platform/analysis-api/src/com/intellij/codeInspection/reference/RefUtil.java
+4 -3
View File
@@ -6,6 +6,7 @@ import com.intellij.codeInspection.ex.EntryPointsManager;
import com.intellij.openapi.util.Comparing;
import com.intellij.psi.PsiElement;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import java.util.Collection;
@@ -18,7 +19,7 @@ import java.util.Collection;
public class RefUtil {
private RefUtil() {}
public static boolean isImplicitUsage(PsiElement element) {
public static boolean isImplicitUsage(@Nullable PsiElement element) {
if (element == null) {
return false;
}
@@ -28,7 +29,7 @@ public class RefUtil {
return false;
}
public static boolean isImplicitRead(PsiElement element) {
public static boolean isImplicitRead(@Nullable PsiElement element) {
if (element == null) {
return false;
}
@@ -47,7 +48,7 @@ public class RefUtil {
return false;
}
public static boolean isImplicitWrite(PsiElement element) {
public static boolean isImplicitWrite(@Nullable PsiElement element) {
if (element == null) {
return false;
}
plugins/InspectionGadgets/testsrc/com/intellij/codeInspection/visibility/AccessCanBeTightenedInspectionTest.java
+3 -3
View File
@@ -449,17 +449,17 @@ public class AccessCanBeTightenedInspectionTest extends LightJavaInspectionTestC
"}");
PlatformTestUtil.registerExtension(Extensions.getRootArea(), ImplicitUsageProvider.EP_NAME, new ImplicitUsageProvider() {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return element instanceof PsiField && "foo".equals(((PsiField)element).getName());
}
}, getTestRootDisposable());
plugins/InspectionGadgets/testsrc/com/siyeh/ig/bugs/MismatchedCollectionQueryUpdateInspectionTest.java
+3 -3
View File
@@ -16,17 +16,17 @@ public class MismatchedCollectionQueryUpdateInspectionTest extends LightJavaInsp
private static final ImplicitUsageProvider TEST_PROVIDER = new ImplicitUsageProvider() {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return element instanceof PsiField && "injected".equals(((PsiField)element).getName());
}
};
plugins/devkit/devkit-core/src/inspections/DevKitImplicitUsageProvider.java
+4 -3
View File
@@ -18,6 +18,7 @@ package org.jetbrains.idea.devkit.inspections;
import com.intellij.codeInsight.daemon.ImplicitUsageProvider;
import com.intellij.psi.*;
import com.intellij.psi.util.InheritanceUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
/**
@@ -26,7 +27,7 @@ import org.jetbrains.annotations.Nullable;
public class DevKitImplicitUsageProvider implements ImplicitUsageProvider {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
if (element instanceof PsiClass) {
final PsiClass psiClass = (PsiClass)element;
return isDomElementClass(psiClass);
@@ -41,12 +42,12 @@ public class DevKitImplicitUsageProvider implements ImplicitUsageProvider {
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return false;
}
plugins/groovy/groovy-psi/src/org/jetbrains/plugins/groovy/findUsages/GrImplicitUsageProvider.java
+3 -3
View File
@@ -31,7 +31,7 @@ import org.jetbrains.plugins.groovy.lang.psi.util.PsiUtil;
*/
public class GrImplicitUsageProvider implements ImplicitUsageProvider {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
if (element instanceof GrMethod) {
final GrMethod method = (GrMethod)element;
@@ -53,13 +53,13 @@ public class GrImplicitUsageProvider implements ImplicitUsageProvider {
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
if (element instanceof GrField && isDelegateAnnotated((GrField)element)) return true;
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return false;
}
plugins/javaFX/src/org/jetbrains/plugins/javaFX/fxml/codeInsight/inspections/JavaFxImplicitUsageProvider.java
+3 -3
View File
@@ -27,7 +27,7 @@ import java.util.List;
public class JavaFxImplicitUsageProvider implements ImplicitUsageProvider {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
if (element instanceof PsiMethod) {
return isImplicitMethodUsage((PsiMethod)element);
}
@@ -60,12 +60,12 @@ public class JavaFxImplicitUsageProvider implements ImplicitUsageProvider {
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
if (element instanceof PsiField) {
final PsiField field = (PsiField)element;
if (!isImplicitFxmlAccess(field)) return false;
plugins/junit/src/com/intellij/execution/junit2/inspection/JUnitImplicitUsageProvider.java
+3 -3
View File
@@ -21,17 +21,17 @@ public class JUnitImplicitUsageProvider implements ImplicitUsageProvider {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return element instanceof PsiParameter && AnnotationUtil.isAnnotated((PsiParameter)element, MOCK, 0) ||
element instanceof PsiField && AnnotationUtil.isAnnotated((PsiField)element, INJECTED_FIELD_ANNOTATIONS, 0);
}
plugins/ui-designer/src/com/intellij/uiDesigner/binding/UIDesignerImplicitUsageProvider.java
+3 -3
View File
@@ -17,7 +17,7 @@ import java.util.stream.Stream;
*/
public class UIDesignerImplicitUsageProvider implements ImplicitUsageProvider {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
if (element instanceof PsiMethod) {
PsiMethod method = (PsiMethod) element;
if ((AsmCodeGenerator.CREATE_COMPONENTS_METHOD_NAME.equals(method.getName()) ||
@@ -30,12 +30,12 @@ public class UIDesignerImplicitUsageProvider implements ImplicitUsageProvider {
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return element instanceof PsiField && FormReferenceProvider.getFormFile((PsiField)element) != null;
}
plugins/xpath/xpath-lang/src/org/intellij/lang/xpath/xslt/impl/XsltImplicitUsagesProvider.java
+4 -3
View File
@@ -14,10 +14,11 @@ import com.intellij.psi.xml.XmlFile;
import com.intellij.util.Query;
import org.intellij.lang.xpath.context.ContextProvider;
import org.intellij.lang.xpath.xslt.XsltSupport;
import org.jetbrains.annotations.NotNull;
public final class XsltImplicitUsagesProvider implements ImplicitUsageProvider {
@Override
public boolean isImplicitUsage(PsiElement element) {
public boolean isImplicitUsage(@NotNull PsiElement element) {
if (!(element instanceof XmlAttribute)) {
return false;
}
@@ -53,12 +54,12 @@ public final class XsltImplicitUsagesProvider implements ImplicitUsageProvider {
}
@Override
public boolean isImplicitRead(PsiElement element) {
public boolean isImplicitRead(@NotNull PsiElement element) {
return false;
}
@Override
public boolean isImplicitWrite(PsiElement element) {
public boolean isImplicitWrite(@NotNull PsiElement element) {
return false;
}
}