MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: fix "'if' statement with identical branches" false positive

Browse Source
This commit is contained in:
Bas Leijdekkers
2016-06-23 14:51:17 +02:00
parent 68d99378ee
commit a02562cadb
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/controlflow/IfStatementWithIdenticalBranchesInspection.java
+5 -3
View File
@@ -174,8 +174,8 @@ public class IfStatementWithIdenticalBranchesInspection
@Override
public void visitIfStatement(@NotNull PsiIfStatement ifStatement) {
super.visitIfStatement(ifStatement);
final PsiStatement elseBranch = unwrap(ifStatement.getElseBranch());
final PsiStatement thenBranch = unwrap(ifStatement.getThenBranch());
final PsiStatement elseBranch = ifStatement.getElseBranch();
final PsiStatement thenBranch = ifStatement.getThenBranch();
if (thenBranch == null) {
return;
}
@@ -194,7 +194,9 @@ public class IfStatementWithIdenticalBranchesInspection
}
}
private boolean isDuplicate(@NotNull PsiElement element1, @NotNull PsiElement element2) {
private boolean isDuplicate(@NotNull PsiStatement element1, @NotNull PsiStatement element2) {
element1 = unwrap(element1);
element2 = unwrap(element2);
final InputVariables inputVariables =
new InputVariables(Collections.emptyList(), element1.getProject(), new LocalSearchScope(element1), false);
final DuplicatesFinder finder = new DuplicatesFinder(new PsiElement[]{element1}, inputVariables, null, Collections.emptyList());
plugins/InspectionGadgets/test/com/siyeh/igtest/controlflow/if_statement_with_identical_branches/IfStatementWithIdenticalBranches.java
+10
View File
@@ -214,4 +214,14 @@ class NotADup {
private Object bar(Object x) {
return null;
}
void nesting(int i, int j) {
if (i == 2) {
System.out.println("2");
} else {
if (j == 2) {
System.out.println("2");
}
}
}
}