MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java] Simplify BuildManagerVersionChecker#updateVersionStrings

Browse Source 
Iterating on ProjectJdkTable is unnecessary to update concerned workspace model entities.

IJ-CR-130133

GitOrigin-RevId: c34529f470feb438330f1e5203f6864ea745b22b
This commit is contained in:
Louis Vignier
2024-05-17 13:36:31 +02:00
committed by intellij-monorepo-bot
parent 7418e0a4e3
commit 9f0b7cec0e
1 changed files with 7 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
java/compiler/impl/src/com/intellij/compiler/server/BuildManagerVersionChecker.kt
View File

@@ -8,7 +8,6 @@ import com.intellij.notification.NotificationType
import com.intellij.openapi.application.ApplicationManager
import com.intellij.openapi.components.Service
import com.intellij.openapi.project.Project
import com.intellij.openapi.projectRoots.ProjectJdkTable
import com.intellij.openapi.roots.ui.configuration.ProjectSettingsService
import com.intellij.platform.backend.workspace.workspaceModel
import com.intellij.platform.workspace.jps.entities.SdkEntity
@@ -52,22 +51,16 @@ internal class BuildManagerVersionChecker(val project: Project, val scope: Corou
}
private suspend fun updateVersionStrings(home: String, versionInfo: JdkVersionDetector.JdkVersionInfo) {
ProjectJdkTable.getInstance().allJdks.filter { it.homePath == home }.forEach { jdk ->
val versionString = versionInfo.displayVersionString()
if (jdk.versionString != versionString) {
val versionString = versionInfo.displayVersionString()
val sdkEntity = (project.workspaceModel.currentSnapshot.entities(SdkEntity::class.java)
.firstOrNull { it.name == jdk.name && it.type == jdk.sdkType.name }
?: error("SDK entity for `${jdk.name}` `${jdk.sdkType.name}` doesn't exist"))
project.workspaceModel.update("Updating JDK versions string") {
it.modifyEntity(sdkEntity) {
this.apply {
version = versionString
}
project.workspaceModel.currentSnapshot.entities(SdkEntity::class.java)
.filter { it.homePath?.url == home && it.version != versionString }
.forEach { sdkEntity ->
project.workspaceModel.update("Updating JDK versions string") { storage ->
storage.modifyEntity(sdkEntity) {
this.version = versionString
}
}
}
}
}
}