MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

testng: check constant values in depends on methods (IDEA-73503 )

Browse Source
This commit is contained in:
anna
2011-08-25 19:26:04 +02:00
parent 0f5615356b
commit 9d2df12225
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/testng/src/com/theoryinpractice/testng/inspection/DependsOnMethodInspection.java
+15 -5
View File
@@ -17,10 +17,7 @@ package com.theoryinpractice.testng.inspection;
import com.intellij.codeInspection.*;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.psi.PsiAnnotation;
import com.intellij.psi.PsiClass;
import com.intellij.psi.PsiMethod;
import com.intellij.psi.PsiNameValuePair;
import com.intellij.psi.*;
import com.theoryinpractice.testng.util.TestNGUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@@ -85,11 +82,24 @@ public class DependsOnMethodInspection extends BaseJavaLocalInspectionTool
if (dep != null) {
if (dep.getValue() != null) {
Matcher matcher = PATTERN.matcher(dep.getValue().getText());
final PsiAnnotationMemberValue value = dep.getValue();
if (value != null) {
String text = value.getText();
if (value instanceof PsiReferenceExpression) {
final PsiElement resolve = ((PsiReferenceExpression)value).resolve();
if (resolve instanceof PsiField && ((PsiField)resolve).hasModifierProperty(PsiModifier.STATIC) && ((PsiField)resolve).hasModifierProperty(PsiModifier.FINAL)) {
final PsiExpression initializer = ((PsiField)resolve).getInitializer();
if (initializer != null) {
text = initializer.getText();
}
}
}
Matcher matcher = PATTERN.matcher(text);
while (matcher.find()) {
String methodName = matcher.group(1);
checkMethodNameDependency(manager, psiClass, methodName, dep, problemDescriptors, isOnTheFly);
}
}
}
}
}